Default test recording sanitizers#22745
Merged
chlowell merged 5 commits intoAzure:mainfrom Apr 16, 2024
Merged
Conversation
Member
Author
|
/azp run go - datalake |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run go - azdatalake |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chlowell
requested review from
RickWinter,
benbp,
jhendrixMSFT,
richardpark-msft and
weshaggard
as code owners
RickWinter
approved these changes
Apr 16, 2024
Member
|
@chlowell thanks for catching that old version pin. We did fix the underlying issues with that IIRC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These will apply to all future recordings made through the proxy but don't affect existing recordings. Some of the new target values may not be secret, however we're scrubbing them all anyway to prevent false positives. We can revisit them later if sanitizing them causes any problems.
I marked
NewRecordingdeprecated because it doesn't use the test proxy and isn't called anywhere in the repo. We should delete it and the rest of the vestigialgo-vcrbased code because we only support recording via the proxy (#22744).Also, I reverted #21142 because it pinned our CI pipelines to an old version of the proxy that doesn't support adding sanitizers in bulk, apparently to work around an azdatalake issue. The azdatalake pipelines pass with this change so I guess the underlying problem has been solved? (@scbedd @benbp)