Skip to content

Test List Blobs Fix for Invalid XML Characters #21342

Merged
siminsavani-msft merged 2 commits intoAzure:feature/azblob-stg85/86from
siminsavani-msft:list-encoded-chars
Aug 10, 2023
Merged

Test List Blobs Fix for Invalid XML Characters #21342
siminsavani-msft merged 2 commits intoAzure:feature/azblob-stg85/86from
siminsavani-msft:list-encoded-chars

Conversation

@siminsavani-msft
Copy link
Copy Markdown
Contributor

@siminsavani-msft siminsavani-msft commented Aug 9, 2023

  • Test to check that invalid blob names are parsed correctly when List Flat & List Hierarchy
  • Changed decoding behavior from base64.StdEncoding.DecodeString to url.QueryUnescape because of error message unmarshalling type *generated.ListBlobsFlatSegmentResponse: illegal base64 data at input byte 4
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Aug 9, 2023
@siminsavani-msft
Copy link
Copy Markdown
Contributor Author

siminsavani-msft commented Aug 9, 2023

/azp run go - azblob

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 9, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft siminsavani-msft marked this pull request as ready for review August 9, 2023 21:23
@siminsavani-msft siminsavani-msft enabled auto-merge (squash) August 9, 2023 21:33
@chlowell
Copy link
Copy Markdown
Member

chlowell commented Aug 10, 2023

/check-enforcer evaluate

@siminsavani-msft siminsavani-msft merged commit 89e0ff3 into Azure:feature/azblob-stg85/86 Aug 10, 2023
@siminsavani-msft siminsavani-msft deleted the list-encoded-chars branch August 10, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmcc-msft seanmcc-msft seanmcc-msft approved these changes

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

@gapra-msft gapra-msft Awaiting requested review from gapra-msft

@bhansalivikas bhansalivikas Awaiting requested review from bhansalivikas

Assignees

No one assigned

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siminsavani-msft @chlowell @seanmcc-msft