Merged
Conversation
chlowell
requested review from
RickWinter,
jhendrixMSFT and
richardpark-msft
as code owners
chlowell
requested review from
KarishmaGhiya,
billwert,
joshfree,
mpodwysocki,
pvaneck,
schaabs and
scottaddie
scottaddie
reviewed
Aug 15, 2023
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
jhendrixMSFT
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big change from the beta design is that CAE becomes a token request option that's off by default. This allows clients to decide whether to acquire CAE tokens, which makes sense because clients are responsible for handling CAE challenges. MSAL will continue to support CAE only as a client option, so our per-request option requires credentials to maintain two MSAL clients. Most of the diff here is adding wrappers to manage that.
Closes #19215