Merged
Conversation
jlaundry
requested review from
bhansalivikas,
gapra-msft,
jhendrixMSFT,
siminsavani-msft,
souravgupta-msft and
tasherif-msft
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @jlaundry! We will review the pull request and get back to you soon. |
Contributor
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
siminsavani-msft
approved these changes
May 8, 2023
Contributor
siminsavani-msft
left a comment
siminsavani-msft
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
tasherif-msft
approved these changes
May 8, 2023
Contributor
Author
|
Hey @siminsavani-msft @tasherif-msft - is there anything left to do before this can be merged? |
souravgupta-msft
approved these changes
May 15, 2023
Member
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run go - azqueue |
|
Azure Pipelines successfully started running 1 pipeline(s). |
siminsavani-msft
approved these changes
May 16, 2023
7 tasks
roelarents
added a commit
to roelarents/loki
that referenced
this pull request
Jun 28, 2024
…default domain (copied from Azure/azure-sdk-for-go#20759)
roelarents
added a commit
to roelarents/loki
that referenced
this pull request
Jun 28, 2024
… with non-default domain (copied from Azure/azure-sdk-for-go#20759)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #20718, this fixes support for Blob and Queue's NewClientFromConnectionString where the connection string uses both a SAS token and (Blob|Queue)Endpoint parameters.
I've also created
azqueue/internal/shared/shared_test.go, using the azblob equivalent as a baseline