Skip to content

[azservicebus, azeventhubs] Stress test and logging improvement #20710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardpark-msft merged 5 commits into from
May 1, 2023
Merged

[azservicebus, azeventhubs] Stress test and logging improvement #20710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60f9241
Add a timestamp, and if tee happens to start again, append rather tha…
Apr 26, 2023
670647d
Updating the logging to print more tracing information (per-link) in …
Apr 26, 2023
524c38a
Trimming out some of the verbose logging, seeing if I can get it a bi…
richardpark-msft Apr 27, 2023
b39481d
Make the constants...actual constants.
richardpark-msft Apr 28, 2023
35e49e8
Log message changed since I shortened things up a bit.
Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/messaging/azeventhubs/internal/eh/stress/deploy.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Set-Location $PSScriptRoot
function deployUsingLocalAddons() {
$azureSDKToolsRoot="<Git clone of azure-sdk-tools>"
$stressTestAddonsFolder = "$azureSDKToolsRoot/tools/stress-cluster/cluster/kubernetes/stress-test-addons"
$clusterResourceGroup = "<Resource Group for Cluster"
$clusterResourceGroup = "<Resource Group for Cluster>"
$clusterSubscription = "<Azure Subscription>"
$helmEnv = "pg2"

Expand Down
6 changes: 3 additions & 3 deletions sdk/messaging/azeventhubs/internal/eh/stress/templates/stress-test-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
- >
set -ex;
mkdir -p "$DEBUG_SHARE";
/app/stress "{{.Stress.testTarget}}" "-rounds" "{{.Stress.rounds}}" "-prefetch" "{{.Stress.prefetch}}" "{{.Stress.verbose}}" "-sleepAfter" "{{.Stress.sleepAfter}}" | tee "${DEBUG_SHARE}/{{ .Stress.Scenario }}.log";
/app/stress "{{.Stress.testTarget}}" "-rounds" "{{.Stress.rounds}}" "-prefetch" "{{.Stress.prefetch}}" "{{.Stress.verbose}}" "-sleepAfter" "{{.Stress.sleepAfter}}" | tee -a "${DEBUG_SHARE}/{{ .Stress.Scenario }}-`date +%s`.log";
# Pulls the image on pod start, always. We tend to push to the same image and tag over and over again
# when iterating, so this is a must.
imagePullPolicy: Always
Expand All @@ -33,8 +33,8 @@ spec:
# just uses 'limits' for both.
resources:
limits:
memory: "1.5Gi"
cpu: "1"
memory: "0.5Gi"
cpu: "0.5"
{{- include "stress-test-addons.container-env" . | nindent 6 }}
{{- end -}}

Expand Down
12 changes: 7 additions & 5 deletions sdk/messaging/azservicebus/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,14 +442,16 @@ func TestClientUnauthorizedCreds(t *testing.T) {
})

t.Run("invalid identity creds", func(t *testing.T) {
tenantID := os.Getenv("AZURE_TENANT_ID")
clientID := os.Getenv("AZURE_CLIENT_ID")
endpoint := os.Getenv("SERVICEBUS_ENDPOINT")
identityVars := test.GetIdentityVars(t)

cliCred, err := azidentity.NewClientSecretCredential(tenantID, clientID, "bogus-client-secret", nil)
if identityVars == nil {
return
}

cliCred, err := azidentity.NewClientSecretCredential(identityVars.TenantID, identityVars.ClientID, "bogus-client-secret", nil)
require.NoError(t, err)

client, err := NewClient(endpoint, cliCred, nil)
client, err := NewClient(identityVars.Endpoint, cliCred, nil)
require.NoError(t, err)

defer test.RequireClose(t, client)
Expand Down
Loading