Skip to content

AppendBlob Client: Transactional/Source Content Validation#20648

Merged
siminsavani-msft merged 9 commits intoAzure:mainfrom
siminsavani-msft:transactional-validation-appendblob
Apr 26, 2023
Merged

AppendBlob Client: Transactional/Source Content Validation#20648
siminsavani-msft merged 9 commits intoAzure:mainfrom
siminsavani-msft:transactional-validation-appendblob

Conversation

@siminsavani-msft
Copy link
Copy Markdown
Contributor

@siminsavani-msft siminsavani-msft commented Apr 17, 2023 •
edited
Loading

  1. AppendBlock
  • Recorded test for existing user generated MD5 (positive and negative).
  • Recorded and added test with positive and negative user generated CRC64
  • Recorded and added test for SDK generated CRC64
  1. AppendBlobFromURL
  • Added test with positive user generated CRC64
  • Added test with negative user generated CRC64 (this test is skipped due to service bug where CRC64 doesn't get checked).
  • User generated MD5 positive and negative already exists
  1. CopyFromURL
  • This API is deprecated from AppendBlob client because it will not work for AppendBlobs so no tests are needed here.
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included. - don't need changelog addition for tests.
  • MIT license headers are included in each file.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 17, 2023
@siminsavani-msft
Copy link
Copy Markdown
Contributor Author

siminsavani-msft commented Apr 26, 2023

/azp run go - azblob

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 26, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Copy Markdown
Contributor Author

siminsavani-msft commented Apr 26, 2023

/azp run go - azblob

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 26, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft siminsavani-msft marked this pull request as ready for review April 26, 2023 18:04
@siminsavani-msft siminsavani-msft changed the title Transactional/Source Content Validation - AppendBlob Client AppendBlob Client: Transactional/Source Content Validation Apr 26, 2023
@siminsavani-msft siminsavani-msft merged commit 8355f0e into Azure:main Apr 26, 2023
@siminsavani-msft siminsavani-msft deleted the transactional-validation-appendblob branch April 26, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gapra-msft gapra-msft gapra-msft approved these changes

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@bhansalivikas bhansalivikas Awaiting requested review from bhansalivikas

+1 more reviewer

@tasherif-msft tasherif-msft tasherif-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AzBlob Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siminsavani-msft @gapra-msft @tasherif-msft @bhansalivikas