Skip to content

Append Blob Tests#20399

Merged
siminsavani-msft merged 11 commits intomainfrom
siminsavani/appendblob-tests
Mar 15, 2023
Merged

Append Blob Tests#20399
siminsavani-msft merged 11 commits intomainfrom
siminsavani/appendblob-tests

Conversation

@siminsavani-msft
Copy link
Copy Markdown
Contributor

@siminsavani-msft siminsavani-msft commented Mar 13, 2023 •
edited
Loading

Adding missing tests for APIs in AppendBlob

Ignored/removed APIs:

  1. SetTier - deprecated from appendblob client, this not an api for appendblob
  2. CopyFromURL - deprecated from appendblob client, this not api for appendblob
  3. AbortCopyFromURL - existing blob base client tests
  4. DownloadFile - existing blob base client tests

Written tests for:

  1. SetMetadata
  2. SetHTTPHeaders
  3. SetTags
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 13, 2023
gapra-msft
gapra-msft reviewed Mar 13, 2023
View reviewed changes
gapra-msft
gapra-msft reviewed Mar 13, 2023
View reviewed changes
jhendrixMSFT
jhendrixMSFT requested changes Mar 13, 2023
View reviewed changes
bhansalivikas
bhansalivikas reviewed Mar 14, 2023
View reviewed changes
@bhansalivikas bhansalivikas added this to the azblob v1.0.1 milestone Mar 14, 2023
souravgupta-msft
souravgupta-msft reviewed Mar 14, 2023
View reviewed changes
jhendrixMSFT
jhendrixMSFT reviewed Mar 14, 2023
View reviewed changes
@siminsavani-msft
Copy link
Copy Markdown
Contributor Author

siminsavani-msft commented Mar 15, 2023

/azp run go - azblob

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 15, 2023

Azure Pipelines successfully started running 1 pipeline(s).

souravgupta-msft
souravgupta-msft reviewed Mar 15, 2023
View reviewed changes
souravgupta-msft
souravgupta-msft reviewed Mar 15, 2023
View reviewed changes
siminsavani-msft and others added 2 commits March 15, 2023 12:34
@siminsavani-msft @souravgupta-msft
Update sdk/storage/azblob/appendblob/client.go
a3257a3 
Co-authored-by: Sourav Gupta <98318303+souravgupta-msft@users.noreply.github.com>
@siminsavani-msft @souravgupta-msft
Update sdk/storage/azblob/appendblob/client.go
6d9792f 
Co-authored-by: Sourav Gupta <98318303+souravgupta-msft@users.noreply.github.com>
@siminsavani-msft siminsavani-msft merged commit 0e71c85 into main Mar 15, 2023
@siminsavani-msft siminsavani-msft deleted the siminsavani/appendblob-tests branch March 15, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@souravgupta-msft souravgupta-msft souravgupta-msft approved these changes

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

+1 more reviewer

@bhansalivikas bhansalivikas bhansalivikas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AzBlob Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

azblob v1.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@siminsavani-msft @jhendrixMSFT @gapra-msft @bhansalivikas @souravgupta-msft