Conversation
siminsavani-msft
requested review from
gapra-msft,
jhendrixMSFT,
souravgupta-msft and
tasherif-msft
as code owners
ghost
added
the
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| func (bb *Client) UploadBlobFromURL(ctx context.Context, copySource string, options *UploadBlobFromURLOptions) (UploadBlobFromURLResponse, error) { | ||
| opts, httpHeaders, leaseAccessConditions, cpkInfo, cpkSourceInfo, modifiedAccessConditions, sourceModifiedConditions := options.format() | ||
|
|
||
| resp, err := bb.generated().PutBlobFromURL(ctx, int64(0), copySource, opts, httpHeaders, leaseAccessConditions, |
There was a problem hiding this comment.
we might need trasacational md5/crc or setting up md5 sum feature here as well.
There was a problem hiding this comment.
We just need to support x-ms-source-content-md5, and it will not be possible for the SDK to pre-calculate this checksum.
There was a problem hiding this comment.
Hold off on this for now, we need to figure out what we are doing with checksuming in AzBlob. Consider this comment non-blocking.
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @scbedd ! I have one recorded test in this PR and recorded it according (1. turned on test-proxy, recorded the test 2. ran the test-proxy command to get a new tag with updated recorded test). The CI is failing because other (unrelated to my PR) recorded tests that were merged are showing this error:
Do you know why is this happening and how I can fix this without having to recorded the recorded tests that are not related to PR? |
|
Closing this PR and creating a new fresh PR here: #20558 |
7 participants
Adding the PutBlobFromUrl API