Conversation
karunmotorq
commented
Feb 13, 2023
- [ x] The purpose of this PR is explained in this or a referenced issue.
- [ x] The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- [ x] Tests are included and/or updated for code changes.
- [ x] Updates to CHANGELOG.md are included.
- [ x] MIT license headers are included in each file.
|
Thank you for your contribution karunmotorq! We will review the pull request and get back to you soon. |
|
Solves #19183 |
|
@microsoft-github-policy-service agree |
ealsur
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Can you please clarify the scenario? The description seems to be for Partition Key None but the code is for Null
|
@ealsur Is there anything else to be done? |
ealsur
left a comment
There was a problem hiding this comment.
@jhendrixMSFT This PR changes the public API surface adding 1 constructor, should I generate the APIView for approval or can it be spot-reviewed?
|
@karunmotorq This PR modifies the public surface, we need approval for public API changes. |
|
@ealsur Is this what was meant? |
ealsur
left a comment
There was a problem hiding this comment.
There's a typo on the variable name, otherwise looks good :)
|
@jhendrixMSFT Are we good on the public surface after the changes? |