Skip to content

Null Partition Key for Cosmos#20002

Merged
ealsur merged 8 commits intoAzure:mainfrom
karunmotorq:main
Feb 15, 2023
Merged

Null Partition Key for Cosmos#20002
ealsur merged 8 commits intoAzure:mainfrom
karunmotorq:main

Conversation

@karunmotorq
Copy link
Copy Markdown
Contributor

  • [ x] The purpose of this PR is explained in this or a referenced issue.
  • [ x] The PR does not update generated files.
  • [ x] Tests are included and/or updated for code changes.
  • [ x] Updates to CHANGELOG.md are included.
  • [ x] MIT license headers are included in each file.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 13, 2023
@ghost
Copy link
Copy Markdown

ghost commented Feb 13, 2023

Thank you for your contribution karunmotorq! We will review the pull request and get back to you soon.

@karunmotorq
Copy link
Copy Markdown
Contributor Author

Solves #19183

@karunmotorq
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Can you please clarify the scenario? The description seems to be for Partition Key None but the code is for Null

@karunmotorq karunmotorq requested review from ealsur and removed request for kirankumarkolli February 14, 2023 05:11
@karunmotorq
Copy link
Copy Markdown
Contributor Author

@ealsur Is there anything else to be done?

Copy link
Copy Markdown
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhendrixMSFT This PR changes the public API surface adding 1 constructor, should I generate the APIView for approval or can it be spot-reviewed?

@ealsur
Copy link
Copy Markdown
Member

ealsur commented Feb 14, 2023

@karunmotorq This PR modifies the public surface, we need approval for public API changes.

@karunmotorq
Copy link
Copy Markdown
Contributor Author

@ealsur Is this what was meant?

Copy link
Copy Markdown
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo on the variable name, otherwise looks good :)

@ealsur ealsur linked an issue Feb 15, 2023 that may be closed by this pull request
@ealsur
Copy link
Copy Markdown
Member

ealsur commented Feb 15, 2023

@jhendrixMSFT Are we good on the public surface after the changes?

@ealsur ealsur merged commit 3909a45 into Azure:main Feb 15, 2023
@ealsur ealsur mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azcosmos: how to leave partition key unset?

4 participants