[azquery] Change MetricsClientQueryResourceOptions.Aggregation from type *string to []*AggregationType

sdk/monitor/azquery/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "go",
   "TagPrefix": "go/monitor/azquery",
-  "Tag": "go/monitor/azquery_98fd781041"
+  "Tag": "go/monitor/azquery_123118d585"
 }

sdk/monitor/azquery/autorest.md

@@ -250,4 +250,15 @@ directive:
     transform: return $.replace(/Timespan \*string/g, "Timespan *TimeInterval");
   - from: metrics_client.go
     where: $
-    transform: return $.replace(/reqQP\.Set\(\"timespan\", \*options\.Timespan\)/g, "reqQP.Set(\"timespan\", string(*options.Timespan))");
+    transform: return $.replace(/reqQP\.Set\(\"timespan\", \*options\.Timespan\)/g, "reqQP.Set(\"timespan\", string(*options.Timespan))");
+
+  # change type of MetricsClientQueryResourceOptions.Aggregation from *string to []*AggregationType
+  - from: models.go
+    where: $
+    transform: return $.replace(/Aggregation \*string/g, "Aggregation []*AggregationType");
+  - from: metrics_client.go
+    where: $
+    transform: return $.replace(/\*options.Aggregation/g, "aggregationTypeToString(options.Aggregation)");
+  - from: swagger-document
+    where: $.parameters.AggregationsParameter
+    transform: $["description"] = "The list of aggregation types to retrieve"

sdk/monitor/azquery/custom_client.go

@@ -192,3 +192,13 @@ func NewBatchQueryRequest(workspaceID string, query string, timespan TimeInterva
 		Headers:       optionsMap,
 	}
 }
+
+// aggregationTypeToString converts []*AggregationType to string, so the values can be sent
+// in MetricsClient.QueryResource
+func aggregationTypeToString(aggregations []*AggregationType) string {
+	var s []string
+	for _, aggregation := range aggregations {
+		s = append(s, string(*aggregation))
+	}
+	return strings.Join(s, ",")
+}

sdk/monitor/azquery/example_test.go

@@ -194,7 +194,7 @@ func ExampleMetricsClient_QueryResource() {
 			Timespan:        to.Ptr(azquery.NewTimeInterval(time.Date(2022, 12, 25, 0, 0, 0, 0, time.UTC), time.Date(2022, 12, 25, 12, 0, 0, 0, time.UTC))),
 			Interval:        to.Ptr("PT1M"),
 			MetricNames:     nil,
-			Aggregation:     to.Ptr("Average,count"),
+			Aggregation:     to.SliceOfPtrs(azquery.AggregationTypeAverage, azquery.AggregationTypeCount),
 			Top:             to.Ptr[int32](3),
 			OrderBy:         to.Ptr("Average asc"),
 			Filter:          to.Ptr("BlobType eq '*'"),

sdk/monitor/azquery/metrics_client_test.go

@@ -42,10 +42,11 @@ func TestQueryResource_BasicQuerySuccess(t *testing.T) {
 	client := startMetricsTest(t)
 	timespan := azquery.TimeInterval("PT12H")
 	res, err := client.QueryResource(context.Background(), resourceURI,
-		&azquery.MetricsClientQueryResourceOptions{Timespan: to.Ptr(timespan),
+		&azquery.MetricsClientQueryResourceOptions{
+			Timespan:        to.Ptr(timespan),
 			Interval:        to.Ptr("PT1M"),
 			MetricNames:     nil,
-			Aggregation:     to.Ptr("Average,count"),
+			Aggregation:     to.SliceOfPtrs(azquery.AggregationTypeAverage, azquery.AggregationTypeCount),
 			Top:             nil,
 			OrderBy:         to.Ptr("Average asc"),
 			Filter:          nil,