fix wrong order of require.Equal arguments#19977
Merged
tadelesh merged 2 commits intoAzure:mainfrom Feb 9, 2023
Merged
Conversation
Member
tadelesh
commented
Feb 8, 2023
tadelesh
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
tadelesh
requested review from
ArcturusZhang,
RickWinter,
chlowell,
lirenhe and
richardpark-msft
as code owners
chlowell
approved these changes
Feb 8, 2023
RickWinter
approved these changes
Feb 9, 2023
Member
RickWinter
left a comment
RickWinter
left a comment
There was a problem hiding this comment.
Agree with using require.True and require.False in the places Charles mentioned.
tadelesh
force-pushed
the
fix_test_equal
branch
from
7b5b3f5 to
4ef6f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.