Skip to content

Copy keyvault/internal to security/keyvault/internal#19879

Merged
chlowell merged 6 commits intoAzure:mainfrom
chlowell:copy-keyvault-internal
Feb 9, 2023
Merged

Copy keyvault/internal to security/keyvault/internal#19879
chlowell merged 6 commits intoAzure:mainfrom
chlowell:copy-keyvault-internal

Conversation

@chlowell
Copy link
Copy Markdown
Member

Part of #17906

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jan 26, 2023
@jhendrixMSFT
Copy link
Copy Markdown
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Copy Markdown
Member

benbp commented Jan 27, 2023

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@chlowell
Copy link
Copy Markdown
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Copy Markdown
Member

benbp commented Jan 30, 2023

/azp run go - internal - securitykeyvault

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Copy Markdown
Member

benbp commented Jan 30, 2023

@chlowell Let me know if you'd like me to update the pipeline generator tool to handle multiple . characters, e.g. go - internal - security-keyvault instead of go - internal - securitykeyvault.

@chlowell
Copy link
Copy Markdown
Member Author

Please do, that would be easier to read.

This regex is the next hurdle. It allows only two segments after sdk/ or resourcemanager/. I don't know how the package properties are used--would it be good enough to capture all but the last segment as the service directory?

@chlowell chlowell requested a review from weshaggard as a code owner February 1, 2023 17:41
@benbp
Copy link
Copy Markdown
Member

benbp commented Feb 1, 2023

If we only capture the final segment, we run into name collisions in a few places. I think we can extend the regex to look for a third segment, but I need to do some more digging to figure out other components that would be affected by this. I think your workaround is ok for now.

@chlowell chlowell force-pushed the copy-keyvault-internal branch from 0f14604 to ab10c06 Compare February 9, 2023 22:05
@chlowell chlowell merged commit dd6cb8b into Azure:main Feb 9, 2023
@chlowell chlowell deleted the copy-keyvault-internal branch February 9, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants