You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@chlowell Let me know if you'd like me to update the pipeline generator tool to handle multiple . characters, e.g. go - internal - security-keyvault instead of go - internal - securitykeyvault.
This regex is the next hurdle. It allows only two segments after sdk/ or resourcemanager/. I don't know how the package properties are used--would it be good enough to capture all but the last segment as the service directory?
If we only capture the final segment, we run into name collisions in a few places. I think we can extend the regex to look for a third segment, but I need to do some more digging to figure out other components that would be affected by this. I think your workaround is ok for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientThis issue points to a problem in the data-plane of the library.KeyVault
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #17906