Skip to content

Updating to Joel's latest PR for go-amqp that removes the session mux#18669

Closed
richardpark-msft wants to merge 2 commits intoAzure:mainfrom
richardpark-msft:sb-test-latest-go-amqp
Closed

Updating to Joel's latest PR for go-amqp that removes the session mux#18669
richardpark-msft wants to merge 2 commits intoAzure:mainfrom
richardpark-msft:sb-test-latest-go-amqp

Conversation

@richardpark-msft
Copy link
Copy Markdown
Member

No description provided.

@richardpark-msft
Copy link
Copy Markdown
Member Author

@jhendrixMSFT , getting a failure with your latest patch, specifically when using websockets:

=== RUN TestNewClientWithWebsockets
/home/ripark/src/_/sb-test-latest-go-amqp/sdk/messaging/azservicebus/client_test.go:110:
Error Trace: client_test.go:110
Error: Received unexpected error:
(connlost): invalid protoHeader
Test: TestNewClientWithWebsockets

@jhendrixMSFT
Copy link
Copy Markdown
Member

@richardpark-msft where can I find more info on the failing test?

@jhendrixMSFT
Copy link
Copy Markdown
Member

@richardpark-msft I have a repro now, investigating...

@jhendrixMSFT
Copy link
Copy Markdown
Member

@richardpark-msft fix applied, great catch.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 23, 2022
@ghost
Copy link
Copy Markdown

ghost commented Sep 23, 2022

Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Sep 30, 2022
@ghost
Copy link
Copy Markdown

ghost commented Sep 30, 2022

Hi @richardpark-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants