(ARMSubscription) fixes Azure/azure-sdk-for-go#18620#18666
(ARMSubscription) fixes Azure/azure-sdk-for-go#18620#18666navba-MSFT wants to merge 1 commit intomainfrom
Conversation
fixes #18620 The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct: tenantId - The subscription tenant ID. tags - The tags attached to the subscription. Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription
|
@navba-MSFT Thank you for looking into this issue 🙇 I'm not super familiar with this repo, but as far as I can tell, the fix will need to be in the underlying OpenAPI JSON spec first, and then the code here should be regerenated. As it stands, it looks like this PR's change will be lost the next time the code is regenerated. |
@hermanschaaf You are right. I have created another PR in the RestAPi specs repo: |
|
@navba-MSFT We do not change the SDK manually. This PR will be closed and after the swagger updated, we will release the new SDK according to service team's release request. |
fixes #18620
The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:
tenantId - The subscription tenant ID.
tags - The tags attached to the subscription.
Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription