Handle a missing CountDetails node in the returned responses for Get<Entity>RuntimeProperties#18213
Merged
richardpark-msft merged 1 commit intoAzure:mainfrom May 23, 2022
Conversation
…Entity>RuntimeProperties. We can't replicate this locally but a customer can and there's no good reason to have a panic() here. For now, we'll return an error so it can be handled in a structured way and we'll see if we can narrow it down.
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error for a missing CountDetails node in the returned responses for GetRuntimeProperties. This doesn't fix the issue in #17868 but it'll stop the panic, which is infinitely worse.