[azservicebus] Adding azservicebus.Error to represent errors that a customer can use programatically.#17786
Merged
richardpark-msft merged 10 commits intoAzure:mainfrom May 5, 2022
Conversation
…nditions they can handle.
richardpark-msft
force-pushed
the
sb-structured-error
branch
from
9c8d03b to
eaa50fe
Compare
richardpark-msft
changed the title
azservicebus.Error to represent errors that a customer can use programatically.
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chlowell
reviewed
May 3, 2022
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
jhendrixMSFT
reviewed
May 4, 2022
added 3 commits
May 4, 2022 10:15
…bus.Error in actionable circumstances.
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
reviewed
May 5, 2022
jhendrixMSFT
reviewed
May 5, 2022
jhendrixMSFT
requested changes
May 5, 2022
jhendrixMSFT
reviewed
May 5, 2022
- Return *azservicebus.Error, not an azservicebus.Error.
jhendrixMSFT
reviewed
May 5, 2022
- Adding in a test for two cases that weren't covered for whatever reason.
jhendrixMSFT
approved these changes
May 5, 2022
Member
Author
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created
azservicebus.Errorto represent errors that a customer can use programatically.azservicebus.Error contains a code that customers can use, which is considered stable and part of the supported API.
Today we only have two codes - CodeLockLost, which comes back if the lock has expired and CodeConnectionLost, which comes back if we failed on an error that is retryable.
Fixes #17283