Skip to content

[Perf] Fixing race conditions in performance#17296

Merged
seankane-msft merged 16 commits intoAzure:mainfrom
seankane-msft:perf-ctx
Mar 16, 2022
Merged

[Perf] Fixing race conditions in performance#17296
seankane-msft merged 16 commits intoAzure:mainfrom
seankane-msft:perf-ctx

Conversation

@seankane-msft
Copy link
Copy Markdown
Contributor

Hopefully this is the last large PR for re-writing portions of the Perf framework

What's changed

  • created a perfRunner struct for handling running a single test
  • Using sync.Mutexs and atomic.Load/Add for eliminating data races
  • improved simplicity of status updates

@seankane-msft seankane-msft added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Mar 14, 2022
@seankane-msft seankane-msft self-assigned this Mar 14, 2022
@check-enforcer
Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

Copy link
Copy Markdown
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is an internal tool and you're obsessively running it I'm not scrutinizing it too hard at the moment. Just found a few things here and there that are probably worth looking at - if you decide to do it later just file an issue and it's all good.

I'd be interested in if you have some other areas you're going to look into here or if this is pretty much the last drop for awhile. If this is going to go into a less active state we could possibly look at adding more testing.

@seankane-msft
Copy link
Copy Markdown
Contributor Author

I'd be interested in if you have some other areas you're going to look into here or if this is pretty much the last drop for awhile. If this is going to go into a less active state we could possibly look at adding more testing.

@richardpark-msft I think this PR is going to put us in a more stable place going forward. I'd love it if you would add servicebus tests. I'm not sure how much overlap there is between your stress tests and these performance tests.

This closes #17177 and #17175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pillar-performance The issue is related to performance, one of our core engineering pillars.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants