[Perf] Fixing race conditions in performance#17296
[Perf] Fixing race conditions in performance#17296seankane-msft merged 16 commits intoAzure:mainfrom
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For track 2 SDKs Issue the following command as a pull request comment:
|
richardpark-msft
left a comment
There was a problem hiding this comment.
Given that this is an internal tool and you're obsessively running it I'm not scrutinizing it too hard at the moment. Just found a few things here and there that are probably worth looking at - if you decide to do it later just file an issue and it's all good.
I'd be interested in if you have some other areas you're going to look into here or if this is pretty much the last drop for awhile. If this is going to go into a less active state we could possibly look at adding more testing.
@richardpark-msft I think this PR is going to put us in a more stable place going forward. I'd love it if you would add servicebus tests. I'm not sure how much overlap there is between your stress tests and these performance tests. |
Hopefully this is the last large PR for re-writing portions of the Perf framework
What's changed
perfRunnerstruct for handling running a single testsync.Mutexs andatomic.Load/Addfor eliminating data races