[azservicebus] Add testing for primitive data types.#17267
Merged
richardpark-msft merged 2 commits intoAzure:mainfrom Mar 9, 2022
Merged
[azservicebus] Add testing for primitive data types.#17267richardpark-msft merged 2 commits intoAzure:mainfrom
richardpark-msft merged 2 commits intoAzure:mainfrom
Conversation
added 2 commits
March 9, 2022 14:29
Moved a test thatw as a unit test into the appropriate receiver_unit_test.go file.
jhendrixMSFT
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds in some tests for #17047, where we were concerned about which primitives can be both sent and deserialized properly.
go-amqp currently lacks support for decoding/encoding the AMQP primitives for TypeCodeDecimal and TypeCodeChar. These don't necessarily have a proper analog where we'd properly round-trip them so we'd need to think about how to implement this in Go, if needed.
Fixes #17047