Skip to content

fix: empty breaking or additive items in changelog #16870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alancere merged 1 commit into from
Jan 21, 2022
Merged

fix: empty breaking or additive items in changelog #16870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions eng/tools/generator/autorest/model/changelog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,21 @@ func writeChangelogForPackage(r *report.Package) string {
md := &markdown.Writer{}

// write breaking changes
md.WriteHeader("Breaking Changes")
for _, item := range getBreakingChanges(r.BreakingChanges) {
md.WriteListItem(item)
breakings := getBreakingChanges(r.BreakingChanges)
if len(breakings) > 0 {
md.WriteHeader("Breaking Changes")
for _, item := range breakings {
md.WriteListItem(item)
}
}

// write additional changes
md.WriteHeader("Features Added")
for _, item := range getNewContents(r.AdditiveChanges) {
md.WriteListItem(item)
additives := getNewContents(r.AdditiveChanges)
if len(additives) > 0 {
md.WriteHeader("Features Added")
for _, item := range additives {
md.WriteListItem(item)
}
}

return md.String()
Expand Down
4 changes: 0 additions & 4 deletions sdk/resourcemanager/resources/armpolicy/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@
- Struct `ErrorAdditionalInfo` has been removed
- Struct `ErrorResponse` has been removed

### Features Added



## 0.2.0 (2022-01-13)
### Breaking Changes

Expand Down