[KeyVault] Add Immutable Property#16857
Merged
seankane-msft merged 14 commits intoAzure:mainfrom Feb 9, 2022
Merged
Conversation
seankane-msft
requested review from
JeffreyRichter,
chlowell,
heaths and
maorleger
Contributor
Author
JeffreyRichter
approved these changes
Jan 28, 2022
heaths
requested changes
Jan 28, 2022
heaths
approved these changes
Jan 31, 2022
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Signing off to unblock, but please be sure to use KeyOperation instead of KeyOperations (should be singular).
heaths
approved these changes
Feb 8, 2022
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
One slight (unfortunate) change, but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate to the latest 7.3-preview swagger and add
KeyReleasePolicyto theClient.UpdateKeyPropertiesmethod.This change hasn't been rolled out to services, this will stay in draft until that is done.