Skip to content

Service Bus - unaligned 64-bit atomic operation when running on mips#16847

Merged
jhendrixMSFT merged 2 commits intoAzure:mainfrom
jackesdavid:main
Jan 18, 2022
Merged

Service Bus - unaligned 64-bit atomic operation when running on mips#16847
jhendrixMSFT merged 2 commits intoAzure:mainfrom
jackesdavid:main

Conversation

@jackesdavid
Copy link
Copy Markdown
Contributor

@jackesdavid jackesdavid commented Jan 16, 2022

Fix the unaligned 64-bit atomic operation in Service Bus

On non-Linux ARM, the 64-bit functions use instructions unavailable before the ARMv6k core.
On ARM, x86-32, and 32-bit MIPS,
it is the caller's responsibility to arrange for 64-bit
alignment of 64-bit words accessed atomically. The first word in a
variable or in an allocated struct, array, or slice can be relied upon to be
64-bit aligned.

Device:Openwrt ( mips Devices)

OS : Linux OpenWrt 5.4.158 #0 SMP Sat Nov 13 20:29:41 2021 mips GNU/Linux

Relase

DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='SNAPSHOT'
DISTRIB_TARGET='ramips/mt7621'
DISTRIB_ARCH='mipsel_24kc'

Golang: go version go1.17.5 windows/amd64

Build Command: GOOS=linux GOARCH=mipsle GOMIPS=softfloat go build -trimpath -ldflags="-s -w"

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost
Copy link
Copy Markdown

ghost commented Jan 16, 2022

Thank you for your contribution jackesdavid! We will review the pull request and get back to you soon.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 16, 2022
@jhendrixMSFT jhendrixMSFT merged commit 3d11d48 into Azure:main Jan 18, 2022
@richardpark-msft
Copy link
Copy Markdown
Member

@jackesdavid - thank you, this is a really interesting bug report!

But now I have a question for you - what are you doing with Service Bus + openWRT? Is this something that's public?

@jackesdavid
Copy link
Copy Markdown
Contributor Author

Hi Friend, its a project for a company, its a really interisting usage on a very low spec hardware ( a router )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants