[azservicebus] Fixing several reliability/recovery bugs#16831

Merged

richardpark-msft merged 58 commits into

richardpark-msft:export-retry-policy-pub

Jan 25, 2022

Commits on Jan 13, 2022

Remove unneeded error types and tests
Richard Park
committed
Creating a Retry() implmentation for SB. Based on what the azcore implementation used for HTTP.
Richard Park
committed
ATOM
Richard Park
committed
Adding in a simple test helper that we can use in internal to create a queue. To avoid circular deps we use entity manager, not the admin client.
Richard Park
committed
NIT: fixing an extra blank line
Richard Park
committed
Changing everything over to using the ServiceBusError info (soon to be renamed)
Richard Park
committed
Renaming ServiceBusError to SBErrInfo to make it more clear that it's not an `error`, just metadata around one.
Richard Park
committed
Remove probably invalid isPermanentNetError classifier.
Richard Park
committed
Trimming more unneeded stuff from errors
Richard Park
committed
The processor type isn't going to ship immediately and it's starting to fall into dangerous "unmaintained" territory. It's best to just remove it and revisit it later.
Richard Park
committed
Add a safety net where test queues are just auto-deleted after being idle for 5 minutes. Makes test cleanup a bit better if you just ctrl+c out of the test suite.
Richard Park
committed
Adding in retries to the session receiver's operations.
Richard Park
committed

Commits on Jan 14, 2022

Adding in some more tests for retries.
Richard Park
committed
Handling different mgmt link errors
Richard Park
committed
Removed the management client - it was just yet another lock around another client. It's now just a set of functions that take an amqpLinks, that internally get the RPCClient instead.
Richard Park
committed
A 1/2 measure, but making it so the admin_client at least returns the proper azcore.ResponseError, which people can use to pick apart the returned response if they want to differentiate between 404…
Richard Park
committed
We no longer use the older retry, preferring our newer one that looks like the azcore version.
Richard Park
committed
Bigger changes here for amqpLinks:
Richard Park
committed
Lots of fixes for namespace:
Richard Park
committed
Converted the one tab.Log into an azure logger and we can stop passing in the unneeded ctx.
Richard Park
committed
Expose the retry options publicly, allowing customers to configure it when they create the client.
Richard Park
committed
Going all in on the Azure logger
Richard Park
committed
- Reducing our dependency on the `messaging/internal` package by moving rpc.go into here.
Richard Park
committed
Removed dependency on 3rd party backoff package
Richard Park
committed
Change over to the new amqpLinks.Retry() function, which properly handles using retryOptions _and_ recovers the links.
Richard Park
committed
Switch over to using amqpLinks.Retry().
Richard Park
committed
Use amqpLinks.Retry(), use azure logging.
Richard Park
committed
Merged isMgmtError into the sberrorinfo code.
Richard Park
committed
update mocks, remove dead code.
Richard Park
committed
Updating stress tests:
Richard Park
committed
Fixing copyright header in finite_peeks.go
Richard Park
committed
Remove unused switch
Richard Park
committed
Updating, error code doesn't look the same between separate 404 style calls.
Richard Park
committed

Commits on Jan 15, 2022

Fixing broken retry tests.
Richard Park
committed
glitched, missed a file
Richard Park
committed
Don't parse the body, it's not actually conforming to anything that I can see. Just return it verbatim, the error message and HTTP status code will be accurate.
Richard Park
committed
Fixiung some more of the HTTP based tests
Richard Park
committed
session link recovery means my bogus way of testing this doesn't work but...it was bogus anyways.
Richard Park
committed
There was overlap between the two interfaces and it turns out one of them is no longer needed now that I got rid of an actual mgmtclient.
Richard Park
committed
lint
Richard Park
committed
ErrorCode isn't going to get filled out. We'll rely on accurate http statuscodes and the .Error() message to give people context.
Richard Park
committed

Commits on Jan 18, 2022

Merge remote-tracking branch 'upstream/main' into export-retry-policy-pub
Richard Park
committed
- Make sure we're 64-bit aligned for our atomic counter values.
Richard Park
committed

Commits on Jan 19, 2022

go mod tidy
Richard Park
committed
Doc comment for retry options in admin_client.go
Richard Park
committed

Commits on Jan 20, 2022

Comments and rename from 'rev' to ID.
Richard Park
committed
Checking in the working stress tests that are testing this changeset, including the stress-test-deployment-lib.ps1.
Richard Park
committed
Test list.
Richard Park
committed
chart.yaml update to a shorter namespace name, for benbp
Richard Park
committed
Merge remote-tracking branch 'upstream/main' into export-retry-policy-pub
Richard Park
committed
revert change to the deploy script
Richard Park
committed
Adding a little bit of documentation for which deps are for the production package, which are for stress tests and which are for testing only.
Richard Park
committed

Commits on Jan 22, 2022

Unneeded break
Richard Park
committed
Mean tot be a type alias.
Richard Park
committed
Remove unneeded retryOptions (it's actually just in args)
Richard Park
committed
retryOptions wasn't supposed to be in args since it's optional.
Richard Park
committed
Fallthrough instead of else.
Richard Park
committed

Commits on Jan 25, 2022

Don't need to zero initialize a struct.
Richard Park
committed