Update Language-Settings for new moduleVersion#16801
Update Language-Settings for new moduleVersion#16801seankane-msft wants to merge 2 commits intomainfrom
Conversation
autorest changed the variable name from `version` to `moduleVersion`
chidozieononiwu
left a comment
chidozieononiwu
left a comment
There was a problem hiding this comment.
You'll also need to update
| { | ||
| $NO_PREFIX_VERSION_LINE_REGEX = ".+\s*=\s*`"(?<bad_version>$([AzureEngSemanticVersion]::SEMVER_REGEX))`"" | ||
| $VERSION_LINE_REGEX = ".+\s*=\s*`".*v(?<version>$([AzureEngSemanticVersion]::SEMVER_REGEX))`"" | ||
| $VERSION_LINE_REGEX = ".+\s*=\s*`".*v(?<moduleVersion>$([AzureEngSemanticVersion]::SEMVER_REGEX))`"" |
There was a problem hiding this comment.
You'll need to update line 24 below.
There was a problem hiding this comment.
Done, thank you
| function Get-GoModuleVersionInfo($modPath) | ||
| { | ||
| $NO_PREFIX_VERSION_LINE_REGEX = ".+\s*=\s*`"(?<bad_version>$([AzureEngSemanticVersion]::SEMVER_REGEX))`"" | ||
| $VERSION_LINE_REGEX = ".+\s*=\s*`".*v(?<version>$([AzureEngSemanticVersion]::SEMVER_REGEX))`"" |
There was a problem hiding this comment.
This is just changing the named group in a RegEx which isn't used outside of this regex and matching. Thus this is pretty much a noop, what is it that you are trying to update?
There was a problem hiding this comment.
The variable name has changed from version to moduleVersion, I am looking for the regex that searches for this
There was a problem hiding this comment.
Looking at this more in depth, I don't think there is a check on the variable version. Is that correct @weshaggard ? It looks like it's doing a search for semantic versioning in a specific file.
There was a problem hiding this comment.
That is correct this regex is only looking for something that looks like "=v". If it finds that in one of the file names we look in hen it assumes that is the module version. If we trying to be more prescriptive then we would want to do something like moduleVersion\s*=\s*``".*v(?<version>$([AzureEngSemanticVersion]::SEMVER_REGEX))``"
If we do this we need to verify that all the existing versions currently match that or it will throw off a number of processes in this repo.
There was a problem hiding this comment.
For now I don't think we need to be more prescriptive. I am going to close this PR.
4 participants
autorest changed the variable name from
versiontomoduleVersion