Skip to content

Add offline test for Azure Arc managed identity #16771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 8 commits into from
Jan 7, 2022
Merged

Add offline test for Azure Arc managed identity #16771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2098164
in cleanup unset env vars having no initial value
chlowell Jan 6, 2022
6b0cb31
Cloud Shell: remove flaky live test, consolidate
chlowell Jan 4, 2022
a4456be
offline test for Arc
chlowell Jan 6, 2022
c1c9f66
consolidate environment variable setting
chlowell Jan 6, 2022
01bab44
skip tests using T.Tempdir on Windows
chlowell Jan 6, 2022
16308f9
thanks, Joel
chlowell Jan 7, 2022
da8d1d4
validate cloud shell requests
chlowell Jan 7, 2022
9ec6bfc
trying again on windows
chlowell Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions sdk/azidentity/azidentity_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,15 @@ const (
// Set environment variables for the duration of a test. Restore their prior values
// after the test completes. Obviated by 1.17's T.Setenv
func setEnvironmentVariables(t *testing.T, vars map[string]string) {
unsetSentinel := "variables having no initial value must be unset after the test"
priorValues := make(map[string]string, len(vars))
for k, v := range vars {
priorValues[k] = os.Getenv(k)
priorValue, ok := os.LookupEnv(k)
if ok {
priorValues[k] = priorValue
} else {
priorValues[k] = unsetSentinel
}
err := os.Setenv(k, v)
if err != nil {
t.Fatalf("Unexpected error setting %s: %v", k, err)
Expand All @@ -41,7 +47,12 @@ func setEnvironmentVariables(t *testing.T, vars map[string]string) {

t.Cleanup(func() {
for k, v := range priorValues {
err := os.Setenv(k, v)
var err error
if v == unsetSentinel {
err = os.Unsetenv(k)
} else {
err = os.Setenv(k, v)
}
if err != nil {
t.Fatalf("Unexpected error resetting %s: %v", k, err)
}
Expand Down
Loading