fix: remove redundant conditon for job in release pipeline by tadelesh · Pull Request #16355 · Azure/azure-sdk-for-go

tadelesh · 2021-12-01T03:17:49Z

The purpose of this PR is explained in this or a referenced issue.
The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
Tests are included and/or updated for code changes.
Updates to CHANGELOG.md are included.
MIT license headers are included in each file.

seankane-msft

Can you verify this works by releasing aztemplate from this branch before merging?

weshaggard · 2021-12-01T22:43:04Z

eng/pipelines/templates/jobs/archetype-go-release.yml

    jobs: 
      - deployment: TagRepository
        displayName: "Create release tag"
-        condition: and(succeeded(), eq(variables['NeedToRelease'], 'true'), ne(variables['Skip.TagRepository'], 'true'))


We only want to remove the "NeedToRelease" part of this condition.

Skip.TagRepository has already been checked with previous stage CheckRelease which is the dependency of this Release stage. So I removed it.

Maybe I'm missing it but I don't see where Skip.TagRepository is checked. Can you point me to the place we check it?

Sorry. I've mixed the two conditions (Skip.Release, Skip.TagRepository) up 😟. I've fixed it.

tadelesh · 2021-12-02T10:43:33Z

Can you verify this works by releasing aztemplate from this branch before merging?

Release: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1224938&view=results
Skip Release: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1224955&view=results

seankane-msft · 2021-12-02T15:55:49Z

Can you verify this works by releasing aztemplate from this branch before merging?

Release: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1224938&view=results

The Release pipeline failed on the Push changes step, that definition is in eng/common, @weshaggard is this a flaky issue or is there anything you see that caused this failure?

weshaggard · 2021-12-02T17:30:57Z

That failure is because it was ran from @tadelesh's fork and test pipeline and not our official template pipeline. @tadelesh can you use our go - aztemplate (https://dev.azure.com/azure-sdk/internal/_build?definitionId=3058) to test? You might need to manually queue it and point it at refs/pull/16355/merge as the branch to test it because some things will not work in our release pipelines if triggered directly from a PR.

tadelesh · 2021-12-03T11:21:34Z

That failure is because it was ran from @tadelesh's fork and test pipeline and not our official template pipeline. @tadelesh can you use our go - aztemplate (https://dev.azure.com/azure-sdk/internal/_build?definitionId=3058) to test? You might need to manually queue it and point it at refs/pull/16355/merge as the branch to test it because some things will not work in our release pipelines if triggered directly from a PR.

Thanks for your suggestion which also help me to know another way to test pipeline change under PR. Release result is here. Some validation failed for the create pull request for new version step. I don't know whether it is due to the merge ref as I haven't changed anything about the Update package version job. Skip release result is here. If there is no more serious problem with this PR, I want to merge it asap as it block the release of some mgmt. SDK.

seankane-msft · 2021-12-03T16:06:13Z

That failure is because it was ran from @tadelesh's fork and test pipeline and not our official template pipeline. @tadelesh can you use our go - aztemplate (https://dev.azure.com/azure-sdk/internal/_build?definitionId=3058) to test? You might need to manually queue it and point it at refs/pull/16355/merge as the branch to test it because some things will not work in our release pipelines if triggered directly from a PR.

Thanks for your suggestion which also help me to know another way to test pipeline change under PR. Release result is here. Some validation failed for the create pull request for new version step. I don't know whether it is due to the merge ref as I haven't changed anything about the Update package version job. Skip release result is here. If there is no more serious problem with this PR, I want to merge it asap as it block the release of some mgmt. SDK.

@weshaggard is the failure on the Release result because it was released from a branch and not from the main branch? Once that issue is fixed, this looks good to me.

weshaggard · 2021-12-03T21:20:36Z

Yes the failure is because we cannot create a pull request against a PR merge that is expected.

@tadelesh once you handle my other feedback about the Skip.TagRepository this change looks good to me.

weshaggard · 2021-12-03T21:22:10Z

@tadelesh while in here can you also address the warning I saw in the logs https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1227441&view=logs&j=f4752989-c568-5678-80f2-0a67848bfa4d. You need to declare the machine pool and image in the CheckRelease stage similar to the other release stage otherwise it uses a default image.

tadelesh · 2021-12-04T07:58:34Z

@tadelesh while in here can you also address the warning I saw in the logs https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1227441&view=logs&j=f4752989-c568-5678-80f2-0a67848bfa4d. You need to declare the machine pool and image in the CheckRelease stage similar to the other release stage otherwise it uses a default image.

Fixed. Test log is here.

* fix: remove redundant conditon for job in release pipeline * build: release aztemplate 0.1.0 to test release pipeline * fix: revert condition of 'Skip.TagRepository' * fix: add pool to 'check release' job to avoid lagging default image

fix: remove redundant conditon for job in release pipeline

91c42f8

tadelesh requested review from seankane-msft and weshaggard December 1, 2021 03:17

tadelesh requested a review from benbp as a code owner December 1, 2021 03:17

tadelesh mentioned this pull request Dec 1, 2021

feat: add check release to auto trigger internal release job #16207

Merged

5 tasks

seankane-msft approved these changes Dec 1, 2021

View reviewed changes

weshaggard reviewed Dec 1, 2021

View reviewed changes

build: release aztemplate 0.1.0 to test release pipeline

75e9428

seankane-msft mentioned this pull request Dec 3, 2021

[Internal] Variable storage #16375

Merged

tadelesh added 2 commits December 4, 2021 14:49

fix: revert condition of 'Skip.TagRepository'

93a8272

fix: add pool to 'check release' job to avoid lagging default image

005fdfe

seankane-msft approved these changes Dec 6, 2021

View reviewed changes

weshaggard approved these changes Dec 6, 2021

View reviewed changes

tadelesh merged commit 28bebb2 into Azure:main Dec 7, 2021

tadelesh deleted the fix_prerelease_pipeline branch December 20, 2021 05:47

Conversation

tadelesh commented Dec 1, 2021

Uh oh!

seankane-msft left a comment

Choose a reason for hiding this comment

Uh oh!

weshaggard Dec 1, 2021

Choose a reason for hiding this comment

Uh oh!

tadelesh Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

weshaggard Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

tadelesh Dec 4, 2021

Choose a reason for hiding this comment

Uh oh!

tadelesh commented Dec 2, 2021

Uh oh!

seankane-msft commented Dec 2, 2021

Uh oh!

weshaggard commented Dec 2, 2021

Uh oh!

tadelesh commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seankane-msft commented Dec 3, 2021

Uh oh!

weshaggard commented Dec 3, 2021

Uh oh!

weshaggard commented Dec 3, 2021

Uh oh!

tadelesh commented Dec 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tadelesh commented Dec 3, 2021 •

edited

Loading