Skip to content

Add Pipelines for keyvault/internal and prepare for release#16113

Merged
seankane-msft merged 16 commits intoAzure:mainfrom
seankane-msft:kv-internal-release
Nov 9, 2021
Merged

Add Pipelines for keyvault/internal and prepare for release#16113
seankane-msft merged 16 commits intoAzure:mainfrom
seankane-msft:kv-internal-release

Conversation

@seankane-msft
Copy link
Copy Markdown
Contributor

@seankane-msft seankane-msft commented Nov 8, 2021

Creates pipelines for keyvault/internal module and prepares for release. Also adds the constants.go file with a version, a LICENSE.txt, ci.keyvault.yml file, and an eng/config.json entry for code coverage

@seankane-msft
Copy link
Copy Markdown
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft seankane-msft requested review from a team and benbp as code owners November 8, 2021 19:02
@seankane-msft
Copy link
Copy Markdown
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft
Copy link
Copy Markdown
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft seankane-msft changed the title Release kv/internal Add Pipelines for keyvault/internal and prepare for release Nov 8, 2021
Copy link
Copy Markdown
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, especially for an internal package.

@seankane-msft seankane-msft merged commit 86daecd into Azure:main Nov 9, 2021
@seankane-msft seankane-msft deleted the kv-internal-release branch November 9, 2021 18:28
jhendrixMSFT pushed a commit to jhendrixMSFT/azure-sdk-for-go that referenced this pull request Jan 12, 2022
)

* Release kv/internal

* adding eng/config entry

* adding ci.yml file

* trying to expand coverage

* renaming to ci.keyvault.yml

* configure Name

* fixing issues

* undoing change to internal/coverage

* add license

* adding changelog date

* add a constant for version

* formatting

* Update sdk/keyvault/internal/constants.go

* fixing tests ignoring errors

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants