Skip to content

Remove AzureGermany Endpoint #16089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 2 commits into from
Nov 5, 2021
Merged

Remove AzureGermany Endpoint #16089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf03f39
Remove AzureGermany Endpoint
chlowell Nov 4, 2021
7f45d09
remove literal from test
chlowell Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk/azcore/arm/client_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ type Endpoint string
const (
// AzureChina is the Azure Resource Manager China cloud endpoint.
AzureChina Endpoint = "https://management.chinacloudapi.cn/"
// AzureGermany is the Azure Resource Manager Germany cloud endpoint.
AzureGermany Endpoint = "https://management.microsoftazure.de/"
// AzureGovernment is the Azure Resource Manager US government cloud endpoint.
AzureGovernment Endpoint = "https://management.usgovcloudapi.net/"
// AzurePublicCloud is the Azure Resource Manager public cloud endpoint.
Expand Down
3 changes: 0 additions & 3 deletions sdk/azcore/internal/shared/shared_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ func TestHasStatusCode(t *testing.T) {
}

func TestEndpointToScope(t *testing.T) {
if s := EndpointToScope("https://management.microsoftazure.de/"); s != "https://management.microsoftazure.de//.default" {
t.Fatalf("unexpected scope %s", s)
}
if s := EndpointToScope("https://management.usgovcloudapi.net"); s != "https://management.usgovcloudapi.net//.default" {
t.Fatalf("unexpected scope %s", s)
}
Expand Down