Sync eng/common directory with azure-sdk-tools for PR 1946#15539
Merged
Sync eng/common directory with azure-sdk-tools for PR 1946#15539
Conversation
azure-sdk
added
Central-EngSys
|
This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:
|
azure-sdk
force-pushed
the
sync-eng/common-spellcheck-requires-filename-1946
branch
2 times, most recently
from
591bcc0 to
0f9388b
Compare
… 'files' config list are excluded by the expressions in 'ignorePaths'
…cript, logic for testing should happen above that and exit appropriately if running tests
azure-sdk
force-pushed
the
sync-eng/common-spellcheck-requires-filename-1946
branch
from
0f9388b to
6511c41
Compare
danieljurek
approved these changes
Sep 13, 2021
azure-sdk
deleted the
sync-eng/common-spellcheck-requires-filename-1946
branch
jay-most
pushed a commit
to jay-most/azure-sdk-for-go
that referenced
this pull request
Sep 18, 2021
* Add ability to exit gracefully when all files in the diff are excluded * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths' * Add tests * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests * Import common instead of logging * Enable strict mode Co-authored-by: Daniel Jurek <djurek@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1946 See eng/common workflow