add manual tag and release pipeline for track2 #15346

tadelesh · 2021-08-20T12:38:32Z

The purpose of this PR is explained in this or a referenced issue.
The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
Tests are included and/or updated for code changes.
Updates to CHANGELOG.md are included.
MIT license headers are included in each file.

tadelesh · 2021-08-20T12:42:09Z

tested in personal repo

chidozieononiwu · 2021-08-23T19:08:07Z

eng/scripts/Language-Settings.ps1

+$RELEASE_TITLE_REGEX = "(?<releaseNoteTitle>^\#+\s+(?<version>v$([AzureEngSemanticVersion]::SEMVER_REGEX))(\s+(?<releaseStatus>\(.+\))))"
+$AUTOREST_VERSION_REGEX = "^module-version:\s+(?<version>$([AzureEngSemanticVersion]::SEMVER_REGEX))"
+
+function Get-go-PackageInfoFromPackageFile ($pkg, $workingDirectory)


Looks like this method can also serve as Get-go-PackageInfoFromRepo, since go only pulls from the repo.

Yes, Go release process has no package process and all package info can get directly from repo. But in order to reuse 'create-tag-and-git-release.ps1' script in eng sys which use Get-go-PackageInfoFromPackageFile to get release info, I create this function by tradeoff.

We should definitely share and reuse this logic for both the packagefile and packageinfo.

@chidozieononiwu at some point I want to eliminate FromPackageFile function completely and either use PackageInfo or use the PackageInfo.json file we are generating as part of the build.

chidozieononiwu · 2021-08-23T19:10:25Z

eng/scripts/Language-Settings.ps1

+# get version from go config auterest.md
+function Get-Version ($pkgPath)
+{
+    $content = Get-Content(Join-Path $pkgPath "autorest.md")


It looks like this only applies to a handfull of management packages. Should there also be logic for retrieving version from version.go files?

I have changed the Get-Version method to support both data plane and mgmt plane. For mgmt plane of go track2, version can be obtained by autorest.md. For data plane, version can be obtained by version.go file. Maybe two version aquisition method can be unified if code gen add version.go to mgmt plane in the future. @jhendrixMSFT @ArcturusZhang

check-enforcer · 2021-08-24T03:37:30Z

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

/check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
/check-enforcer override; by-pass Check Enforcer (approvals still required).

eng/scripts/Language-Settings.ps1

benbp · 2021-08-25T20:27:14Z

A few powershell syntax nits (calling powershell functions via () is the equivalent to passing an array as a single argument and will break when args > 1). Otherwise looks good to me.

seankane-msft · 2021-08-26T17:14:19Z

eng/scripts/Language-Settings.ps1

+# get version from go config auterest.md
+function Get-Version ($pkgPath)


@chidozieononiwu How are we getting the version in go? I believe Joel and yourself settled on including it in a constants.go, this should be updated to include that.

You are right. I am not sure the changes have been mad
e for all the client packages. However @tadelesh if its not too much trouble can you also support getting versions from constants.go file if version.go is absent.

@seankane-msft @chidozieononiwu I've changed Get-Version method to the following logic to support several kinds of version set situation in go sdk:

get all files with constants.go or version.go suffix under module folder

find first string assignment statement in these files with semantic version sub-string by regex expression

benbp · 2021-09-01T20:41:24Z

eng/pipelines/templates/jobs/archetype-go-release.yml

+  ServiceDirectory: ''
+
+stages:
+  - ${{if and(eq(variables['Build.Reason'], 'Manual'), eq(variables['System.TeamProject'], 'internal'))}}:


I think this conditional is unnecessary since you're also including it in the template include for the archetype-sdk-client.yml file.

eng/scripts/Language-Settings.ps1

weshaggard · 2021-09-01T23:27:04Z

eng/scripts/Language-Settings.ps1

+    exit 1
+}
+
+# rewrite from artifact-metadata-parsing.ps1 as all 0.x.x version should be considered prerelease in go sdk


FYI I'm adding support for v0 versions in our core SemVer helper with Azure/azure-sdk-tools#1972. If that is included do we still need to duplicate this entire function? Hopefully not.

It will be great that semver helper can handle this. I'll remove it after your pr merged and automatic sync done.

My SemVer change is in.

eng/scripts/Language-Settings.ps1

weshaggard · 2021-09-01T23:29:17Z

eng/scripts/Language-Settings.ps1

+$Language = "go"
+$packagePattern = "go.mod"
+# rewrite from ChangeLog-Operations.ps1 used in Get-ChangeLogEntriesFromContent for go uses vx.x.x as version number
+$RELEASE_TITLE_REGEX = "(?<releaseNoteTitle>^\#+\s+(?<version>v$([AzureEngSemanticVersion]::SEMVER_REGEX))(\s+(?<releaseStatus>\(.+\))))"


@chidozieononiwu we consider adding an option "v?" to our core regex instead of duplicating this. We do similar support for python in our Regex already which supports different prerelease labels.

I wonder whether there's already a definitely plan for this version compatibility change. Could we use the rewrite workaround before the eventually solution cause there are lots of release work for mgmt plane sdk refreshment recently.

There isn't a plan for this currently and I think what you have is an acceptable workaround for now.

eng/scripts/Language-Settings.ps1

weshaggard

If possible remove your CreateReleases function assuming it isn't needed after my SemVer change. Otherwise the changes look like a good starting point and we can tweak as we start to use it.

…r module folders

…ne it

* add manual tag and release pipeline for track2 * fix: get version support data plane * chore: refine powershell syntax * feat: use regrex to fetch version from all possible version file under module folders * fix: polish according to pr review * fix: remove rewrite CreateReleases function as eng sys has already done it

tadelesh requested review from ArcturusZhang, benbp and chamons August 20, 2021 12:38

tadelesh requested a review from a team as a code owner August 20, 2021 12:38

tadelesh requested a review from weshaggard August 23, 2021 05:30

chidozieononiwu reviewed Aug 23, 2021

View reviewed changes

tadelesh requested a review from chidozieononiwu August 24, 2021 04:26

benbp reviewed Aug 25, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

benbp reviewed Aug 25, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

benbp reviewed Aug 25, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

benbp reviewed Aug 25, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

benbp reviewed Aug 25, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

tadelesh force-pushed the tag_and_release_pipeline branch 2 times, most recently from aa2b872 to 2632eb8 Compare August 26, 2021 03:02

tadelesh requested a review from benbp August 26, 2021 03:03

seankane-msft reviewed Aug 26, 2021

View reviewed changes

tadelesh force-pushed the tag_and_release_pipeline branch 2 times, most recently from 9478617 to b94ca18 Compare August 27, 2021 03:41

tadelesh requested a review from seankane-msft August 27, 2021 03:42

tadelesh force-pushed the tag_and_release_pipeline branch from b94ca18 to b39491b Compare August 27, 2021 03:42

benbp reviewed Sep 1, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

benbp approved these changes Sep 1, 2021

View reviewed changes

weshaggard reviewed Sep 1, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Sep 1, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Sep 1, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Sep 1, 2021

View reviewed changes

eng/scripts/Language-Settings.ps1 Outdated Show resolved Hide resolved

weshaggard mentioned this pull request Sep 1, 2021

Add Get-AllPackageInfoFromRepo function #15329

Closed

tadelesh requested a review from weshaggard September 2, 2021 06:52

weshaggard approved these changes Sep 2, 2021

View reviewed changes

tadelesh added 6 commits September 3, 2021 11:00

add manual tag and release pipeline for track2

99de990

fix: get version support data plane

f947a75

chore: refine powershell syntax

5b15e1a

feat: use regrex to fetch version from all possible version file unde…

5d55672

…r module folders

fix: polish according to pr review

f2f5e75

fix: remove rewrite CreateReleases function as eng sys has already do…

6737356

…ne it

tadelesh force-pushed the tag_and_release_pipeline branch from bc43f99 to 6737356 Compare September 3, 2021 03:08

tadelesh merged commit 694c7a9 into Azure:main Sep 3, 2021

tadelesh deleted the tag_and_release_pipeline branch September 3, 2021 04:43

		# get version from go config auterest.md
		function Get-Version ($pkgPath)

add manual tag and release pipeline for track2 #15346

add manual tag and release pipeline for track2 #15346

Uh oh!

Conversation

tadelesh commented Aug 20, 2021

Uh oh!

tadelesh commented Aug 20, 2021

Uh oh!

chidozieononiwu Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chidozieononiwu Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

check-enforcer bot commented Aug 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benbp commented Aug 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tadelesh Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weshaggard left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chidozieononiwu Aug 23, 2021 •

edited

Loading

chidozieononiwu Aug 23, 2021 •

edited

Loading

tadelesh Aug 27, 2021 •

edited

Loading