[Tables] Add authentication via SAS credential

eng/pipelines/templates/steps/build-test.yml

@@ -37,7 +37,7 @@ steps:
       foreach ($td in $testDirs) {
         pushd $td
 
-        $(Build.SourcesDirectory)/eng/scripts/start-server.ps1 start
+        $(Build.SourcesDirectory)/eng/scripts/proxy-server.ps1 start
 
         Write-Host "##[command]Executing go test -run "^Test" -v -coverprofile coverage.txt $td | go-junit-report -set-exit-code > report.xml"
         go test -run "^Test" -v -coverprofile coverage.txt . > temp.txt
@@ -49,7 +49,7 @@ steps:
           rm coverage.txt
         }
 
-        $(Build.SourcesDirectory)/eng/scripts/start-server.ps1 stop
+        $(Build.SourcesDirectory)/eng/scripts/proxy-server.ps1 stop
       }
     displayName: 'Run Tests'
     workingDirectory: '${{parameters.GoWorkspace}}'

sdk/azcore/request.go

@@ -66,24 +66,34 @@ func (ov opValues) get(value interface{}) bool {
 	return ok
 }
 
+func stripQueryParams(path string) (string, string) {
+	if strings.Contains(path, "?") {
+		splitPath := strings.Split(path, "?")
+		return splitPath[0], splitPath[1]
+	}
+	return path, ""
+}
+
 // JoinPaths concatenates multiple URL path segments into one path,
-// inserting path separation characters as required.
-func JoinPaths(paths ...string) string {
+// inserting path separation characters as required. JoinPaths will preserve
+// query parameters in the root path
+func JoinPaths(root string, paths ...string) string {
 	if len(paths) == 0 {
-		return ""
-	}
-	path := paths[0]
-	for i := 1; i < len(paths); i++ {
-		if path[len(path)-1] == '/' && paths[i][0] == '/' {
-			// strip off trailing '/' to avoid doubling up
-			path = path[:len(path)-1]
-		} else if path[len(path)-1] != '/' && paths[i][0] != '/' {
-			// add a trailing '/'
-			path = path + "/"
-		}
-		path += paths[i]
+		return root
+	}
+
+	root, qps := stripQueryParams(root)
+
+	for i := 0; i < len(paths); i++ {
+		root = strings.TrimRight(root, "/")
+		paths[i] = strings.TrimLeft(paths[i], "/")
+		root += "/" + paths[i]
+	}
+
+	if qps != "" {
+		return strings.Join([]string{root, qps}, "?")
 	}
-	return path
+	return root
 }
 
 // NewRequest creates a new Request with the specified input.

sdk/azcore/request_test.go

@@ -507,7 +507,7 @@ func TestNewRequestFail(t *testing.T) {
 }
 
 func TestJoinPaths(t *testing.T) {
-	if path := JoinPaths(); path != "" {
+	if path := JoinPaths(""); path != "" {
 		t.Fatalf("unexpected path %s", path)
 	}
 	const expected = "http://test.contoso.com/path/one/path/two/path/three/path/four/"

sdk/tables/aztable/byte_array_response.go

@@ -9,7 +9,7 @@ import (
 	"time"
 )
 
-// ByteArrayResponse converts the MapOfInterfaceResponse.Value from a map[string]interface{} to a []byte
+// ByteArrayResponse is the return type for a GetEntity operation. The entities properties are stored in the Value property
 type ByteArrayResponse struct {
 	// ClientRequestID contains the information returned from the x-ms-client-request-id header response.
 	ClientRequestID *string
@@ -45,6 +45,7 @@ type ByteArrayResponse struct {
 	XMSContinuationNextRowKey *string
 }
 
+// newByteArrayResponse converts a MapofInterfaceResponse from a map[string]interface{} to a []byte.
 func newByteArrayResponse(m MapOfInterfaceResponse) (ByteArrayResponse, error) {
 	marshalledValue, err := json.Marshal(m.Value)
 	if err != nil {
@@ -65,8 +66,8 @@ func newByteArrayResponse(m MapOfInterfaceResponse) (ByteArrayResponse, error) {
 	}, nil
 }
 
-// TableEntityQueryByteResponseResponse is the response envelope for operations that return a TableEntityQueryResponse type.
-type TableEntityQueryByteResponseResponse struct {
+// TableEntityListByteResponseResponse is the response envelope for operations that return a TableEntityQueryResponse type.
+type TableEntityListByteResponseResponse struct {
 	// ClientRequestID contains the information returned from the x-ms-client-request-id header response.
 	ClientRequestID *string
 
@@ -101,12 +102,12 @@ type TableEntityQueryByteResponse struct {
 	Value [][]byte
 }
 
-func castToByteResponse(resp *TableEntityQueryResponseResponse) (TableEntityQueryByteResponseResponse, error) {
+func castToByteResponse(resp *TableEntityQueryResponseResponse) (TableEntityListByteResponseResponse, error) {
 	marshalledValue := make([][]byte, 0)
 	for _, e := range resp.TableEntityQueryResponse.Value {
 		m, err := json.Marshal(e)
 		if err != nil {
-			return TableEntityQueryByteResponseResponse{}, err
+			return TableEntityListByteResponseResponse{}, err
 		}
 		marshalledValue = append(marshalledValue, m)
 	}
@@ -116,7 +117,7 @@ func castToByteResponse(resp *TableEntityQueryResponseResponse) (TableEntityQuer
 		Value:         marshalledValue,
 	}
 
-	return TableEntityQueryByteResponseResponse{
+	return TableEntityListByteResponseResponse{
 		ClientRequestID:                 resp.ClientRequestID,
 		Date:                            resp.Date,
 		RawResponse:                     resp.RawResponse,
@@ -127,3 +128,54 @@ func castToByteResponse(resp *TableEntityQueryResponseResponse) (TableEntityQuer
 		XMSContinuationNextRowKey:       resp.XMSContinuationNextRowKey,
 	}, nil
 }
+
+type TableListResponse struct {
+	// The metadata response of the table.
+	OdataMetadata *string `json:"odata.metadata,omitempty"`
+
+	// List of tables.
+	Value []*TableResponseProperties `json:"value,omitempty"`
+}
+
+func tableListResponseFromQueryResponse(q *TableQueryResponse) *TableListResponse {
+	return &TableListResponse{
+		OdataMetadata: q.OdataMetadata,
+		Value:         q.Value,
+	}
+}
+
+// TableListResponseResponse stores the results of a ListTables operation
+type TableListResponseResponse struct {
+	// ClientRequestID contains the information returned from the x-ms-client-request-id header response.
+	ClientRequestID *string
+
+	// Date contains the information returned from the Date header response.
+	Date *time.Time
+
+	// RawResponse contains the underlying HTTP response.
+	RawResponse *http.Response
+
+	// RequestID contains the information returned from the x-ms-request-id header response.
+	RequestID *string
+
+	// The properties for the table query response.
+	TableListResponse *TableListResponse
+
+	// Version contains the information returned from the x-ms-version header response.
+	Version *string
+
+	// XMSContinuationNextTableName contains the information returned from the x-ms-continuation-NextTableName header response.
+	XMSContinuationNextTableName *string
+}
+
+func listResponseFromQueryResponse(q TableQueryResponseResponse) *TableListResponseResponse {
+	return &TableListResponseResponse{
+		ClientRequestID:              q.ClientRequestID,
+		Date:                         q.Date,
+		RawResponse:                  q.RawResponse,
+		RequestID:                    q.RequestID,
+		TableListResponse:            tableListResponseFromQueryResponse(q.TableQueryResponse),
+		Version:                      q.Version,
+		XMSContinuationNextTableName: q.XMSContinuationNextTableName,
+	}
+}

sdk/tables/aztable/cosmos_patch_transform_policy.go

@@ -11,10 +11,10 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 )
 
-// CosmosPatchTransformPolicy transforms PATCH requests into POST requests with the "X-HTTP-Method":"MERGE" header set.
-type CosmosPatchTransformPolicy struct{}
+// cosmosPatchTransformPolicy transforms PATCH requests into POST requests with the "X-HTTP-Method":"MERGE" header set.
+type cosmosPatchTransformPolicy struct{}
 
-func (p CosmosPatchTransformPolicy) Do(req *azcore.Request) (*azcore.Response, error) {
+func (p cosmosPatchTransformPolicy) Do(req *azcore.Request) (*azcore.Response, error) {
 	transformPatchToCosmosPost(req)
 	return req.Next()
 }

sdk/tables/aztable/errors.go

@@ -3,6 +3,10 @@
 
 package aztable
 
+import "errors"
+
+var errInvalidUpdateMode = errors.New("invalid EntityUpdateMode")
+
 func checkEntityForPkRk(entity *map[string]interface{}, err error) error {
 	if _, ok := (*entity)[partitionKey]; !ok {
 		return partitionKeyRowKeyError

sdk/tables/aztable/go.mod

@@ -4,6 +4,7 @@ go 1.13
 
 replace github.com/Azure/azure-sdk-for-go/sdk/internal => ../../internal
 replace github.com/Azure/azure-sdk-for-go/sdk/azidentity => ../../azidentity
+replace github.com/Azure/azure-sdk-for-go/sdk/azcore => ../../azcore
 
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.16.2

sdk/tables/aztable/proxy_test.go

@@ -91,10 +91,10 @@ func createTableServiceClientForRecording(t *testing.T, serviceURL string, cred
 func initClientTest(t *testing.T, service string, createTable bool) (*TableClient, func()) {
 	var client *TableClient
 	var err error
-	if service == string(StorageEndpoint) {
+	if service == string(storageEndpoint) {
 		client, err = createStorageTableClient(t)
 		require.NoError(t, err)
-	} else if service == string(CosmosEndpoint) {
+	} else if service == string(cosmosEndpoint) {
 		client, err = createCosmosTableClient(t)
 		require.NoError(t, err)
 	}
@@ -118,10 +118,10 @@ func initClientTest(t *testing.T, service string, createTable bool) (*TableClien
 func initServiceTest(t *testing.T, service string) (*TableServiceClient, func()) {
 	var client *TableServiceClient
 	var err error
-	if service == string(StorageEndpoint) {
+	if service == string(storageEndpoint) {
 		client, err = createStorageServiceClient(t)
 		require.NoError(t, err)
-	} else if service == string(CosmosEndpoint) {
+	} else if service == string(cosmosEndpoint) {
 		client, err = createCosmosServiceClient(t)
 		require.NoError(t, err)
 	}
@@ -226,7 +226,7 @@ func clearAllTables(service *TableServiceClient) error {
 	pager := service.ListTables(nil)
 	for pager.NextPage(ctx) {
 		resp := pager.PageResponse()
-		for _, v := range resp.TableQueryResponse.Value {
+		for _, v := range resp.TableListResponse.Value {
 			_, err := service.DeleteTable(ctx, *v.TableName, nil)
 			if err != nil {
 				return err