Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/internal/testframework/recording_sanitizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var sanitizedValueSlice = []string{SanitizedValue}

func DefaultSanitizer(recorder *recorder.Recorder) *RecordingSanitizer {
// The default sanitizer sanitizes the Authorization header
s := &RecordingSanitizer{headersToSanitize: map[string]*string{"Authorization": nil}, recorder: recorder, urlSanitizer: DefaultStringSanitizer}
s := &RecordingSanitizer{headersToSanitize: map[string]*string{"Authorization": nil}, recorder: recorder, urlSanitizer: DefaultStringSanitizer, bodySanitizer: DefaultStringSanitizer}
recorder.AddSaveFilter(s.applySaveFilter)

return s
Expand Down
2 changes: 1 addition & 1 deletion sdk/internal/testframework/recording_sanitizer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,4 @@ func NewMockRoundTripper(server *mock.Server) *mockRoundTripper {

func (m *mockRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
return m.server.Do(req)
}
}
2 changes: 1 addition & 1 deletion sdk/tables/aztables/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Release History

## v0.1.0 (Unreleased)
## 0.1.0 (Unreleased)
8 changes: 6 additions & 2 deletions sdk/tables/aztables/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ module github.com/Azure/azure-sdk-for-go/sdk/tables/aztables

go 1.13

replace github.com/Azure/azure-sdk-for-go/sdk/internal => ../../internal

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.1
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.2
github.com/Azure/azure-sdk-for-go/sdk/internal v0.5.0
github.com/google/uuid v1.2.0 // indirect
github.com/stretchr/testify v1.7.0
)
24 changes: 20 additions & 4 deletions sdk/tables/aztables/go.sum
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.1 h1:7JdDsau2B5IZc0d0CPvSMn8DxJ3GRBxtFS7OrZPIJdA=
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.1/go.mod h1:pElNP+u99BvCZD+0jOlhI9OC/NB2IDTOTGZOZH0Qhq8=
github.com/Azure/azure-sdk-for-go/sdk/internal v0.5.0 h1:HG1ggl8L3ZkV/Ydanf7lKr5kkhhPGCpWdnr1J6v7cO4=
github.com/Azure/azure-sdk-for-go/sdk/internal v0.5.0/go.mod h1:k4KbFSunV/+0hOHL1vyFaPsiYQ1Vmvy1TBpmtvCDLZM=
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.2 h1:jBp1eg+iY1S6SEjISakVfHmvDxfj8bg1Mw9JFwpCKag=
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.14.2/go.mod h1:pElNP+u99BvCZD+0jOlhI9OC/NB2IDTOTGZOZH0Qhq8=
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/dnaeon/go-vcr v1.1.0 h1:ReYa/UBrRyQdant9B4fNHGoCNKw6qh6P0fsdGmZpR7c=
github.com/dnaeon/go-vcr v1.1.0/go.mod h1:M7tiix8f0r6mKKJ3Yq/kqU1OYf3MnfmBWVbPx/yU9ko=
github.com/google/uuid v1.2.0 h1:qJYtXnJRWmpe7m/3XlyhrsLrEURqHRM2kxzoxXqyUDs=
github.com/google/uuid v1.2.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/kr/pretty v0.2.1 h1:Fmg33tUaq4/8ym9TJN1x7sLJnHVwhP33CNkpYV/7rwI=
github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
github.com/modocache/gover v0.0.0-20171022184752-b58185e213c5/go.mod h1:caMODM3PzxT8aQXRPkAt8xlV/e7d7w8GM5g0fa5F0D8=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
Expand All @@ -19,5 +29,11 @@ golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.3 h1:cokOdA+Jmi5PJGXLlLllQSgYigAEfHXJAERHVMaCc2k=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
COSMOS_TABLES_ENDPOINT_SUFFIX: cosmos.azure.com
TABLES_COSMOS_ACCOUNT_NAME: chrisstablesprim
TABLES_PRIMARY_COSMOS_ACCOUNT_KEY: Kg==
randomSeed: "1617573293"
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
---
version: 1
interactions:
- request:
body: '{"TableName":"gotablecwmvbx3xi23m7"}'
form: {}
headers:
Accept:
- application/json;odata=minimalmetadata
Authorization:
- sanitized
Content-Length:
- "36"
Content-Type:
- application/json
Dataserviceversion:
- "3.0"
User-Agent:
- azsdk-go-tables/<version> azsdk-go-tables/<version> azcore/v0.13.4 (go1.16.2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The telemetry string in the generated code needs to be updated to replace <version> with v0.1.0.
Also just noticed shouldn't it have generated with azsdk-go-aztables? instead of just ending with tables

Windows_NT)
X-Ms-Date:
- Sun, 04 Apr 2021 21:54:53 GMT
X-Ms-Version:
- "2019-02-02"
url: https://chrisstablesprim.table.cosmos.azure.com/Tables
method: POST
response:
body: '{"TableName":"gotablecwmvbx3xi23m7","odata.metadata":"https://chrisstablesprim.table.cosmos.azure.com/$metadata#Tables/@Element"}'
headers:
Content-Type:
- application/json;odata=minimalmetadata
Date:
- Sun, 04 Apr 2021 21:54:53 GMT
Etag:
- W/"datetime'2021-04-04T21%3A54%3A53.3743624Z'"
Location:
- https://chrisstablesprim.table.cosmos.azure.com/Tables('gotablecwmvbx3xi23m7')
Server:
- Microsoft-HTTPAPI/2.0
X-Ms-Request-Id:
- 33edc858-c2fc-436f-a0a0-8f909cfd1114
status: 201 Created
code: 201
duration: ""
- request:
body: ""
form: {}
headers:
Accept:
- application/json
Authorization:
- sanitized
User-Agent:
- azsdk-go-tables/<version> azsdk-go-tables/<version> azcore/v0.13.4 (go1.16.2;
Windows_NT)
X-Ms-Date:
- Sun, 04 Apr 2021 21:54:53 GMT
X-Ms-Version:
- "2019-02-02"
url: https://chrisstablesprim.table.cosmos.azure.com/Tables('gotablecwmvbx3xi23m7')
method: DELETE
response:
body: ""
headers:
Content-Length:
- "0"
Date:
- Sun, 04 Apr 2021 21:54:53 GMT
Server:
- Microsoft-HTTPAPI/2.0
X-Ms-Request-Id:
- 654da1b1-025b-451e-8d64-d3c4afe7739a
status: 204 No Content
code: 204
duration: ""
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
COSMOS_TABLES_ENDPOINT_SUFFIX: cosmos.azure.com
TABLES_COSMOS_ACCOUNT_NAME: chrisstablesprim
TABLES_PRIMARY_COSMOS_ACCOUNT_KEY: Kg==
randomSeed: "1617573294"
Loading