Moving common dependencies of the tools to a internal package and convert it to a module#14650
Merged
ArcturusZhang merged 24 commits intoAzure:masterfrom May 19, 2021
Conversation
Member
Author
|
Please do not merge this PR because we still do not resolve the ambiguous import issue now. |
ArcturusZhang
force-pushed
the
moving-common-dependencies-to-common-package
branch
from
508b0ae to
f2619b7
Compare
ArcturusZhang
changed the title
common package and convert it to a moduleinternal package and convert it to a module
Member
Author
|
Do you think we need to create CI for every tool after we change tools into modules? @jhendrixMSFT |
Member
|
It would be ideal to create a pipeline just for tools so that you don't have to run track 1 CI which takes forever. |
ArcturusZhang
force-pushed
the
moving-common-dependencies-to-common-package
branch
3 times, most recently
from
5390c82 to
8106ae4
Compare
Member
Author
Since it might not be easy after a bit rounds of trying, I decide we could introduce that later after some offline discussion. |
ArcturusZhang
force-pushed
the
moving-common-dependencies-to-common-package
branch
from
8106ae4 to
7fc97a2
Compare
…1 to module again
ArcturusZhang
force-pushed
the
moving-common-dependencies-to-common-package
branch
from
7fc97a2 to
c61cf9a
Compare
Member
Author
|
Hi @jhendrixMSFT could you please take a look again? After this PR gets merged, the steps should be
|
jhendrixMSFT
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates
tools/internalmodule consisting of the packages that are widely used by some tools we are having, includingtools/apidiff/deltatools/apidiff/exportstools/apidiff/reporttools/apidiff/markdowntools/apidiff/repotools/internal/dirstools/internal/modinfotools/internal/ioextThe following tools are removed:
pickeris removed in this PR, because it is no longer used and it is referencingapidiffas a dependency.versioneris removed in this PR, we will remain the track 1 SDK un-moduled and do not introduce major version sub-directory in track 2, therefore we no longer need its functionality any moreThis PR also creates module for every tool in the
toolsdirectory.