Skip to content

Track2: azcore log remove some duplicate code #14549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 2 commits into from
Apr 20, 2021
Merged

Track2: azcore log remove some duplicate code #14549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7979982
azcore: log remove some duplicate code
magodo Apr 19, 2021
8e9c62f
revert Write()
magodo Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/azcore/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func (l *Logger) Should(cls LogClassification) bool {
// Write invokes the underlying Listener with the specified classification and message.
// If the classification shouldn't be logged or there is no listener then Write does nothing.
func (l *Logger) Write(cls LogClassification, message string) {
if l.lst == nil || !l.Should(cls) {
if !l.Should(cls) {
return
}
l.lst(cls, message)
Expand All @@ -86,7 +86,7 @@ func (l *Logger) Write(cls LogClassification, message string) {
// Writef invokes the underlying Listener with the specified classification and formatted message.
// If the classification shouldn't be logged or there is no listener then Writef does nothing.
func (l *Logger) Writef(cls LogClassification, format string, a ...interface{}) {
if l.lst == nil || !l.Should(cls) {
if !l.Should(cls) {
return
}
l.lst(cls, fmt.Sprintf(format, a...))
Expand Down