Skip to content

Double-check SwaggerToSdk for GO#1100

Closed
lmazuel wants to merge 1 commit intoAzure:latestfrom
lmazuel:cdntest
Closed

Double-check SwaggerToSdk for GO#1100
lmazuel wants to merge 1 commit intoAzure:latestfrom
lmazuel:cdntest

Conversation

@lmazuel
Copy link
Copy Markdown
Member

@lmazuel lmazuel commented Feb 20, 2018

@marstr Could you double-check that everything is here is what you would expect from:
Azure/azure-rest-api-specs#2514

except profiles, since we still have to figure this out.

Thanks!

FYI @salameer

@ghost ghost assigned lmazuel Feb 20, 2018
@ghost ghost added the review label Feb 20, 2018
@lmazuel lmazuel requested a review from marstr February 20, 2018 22:12
@lmazuel lmazuel removed their assignment Feb 20, 2018
@marstr
Copy link
Copy Markdown
Member

marstr commented Feb 21, 2018

Looks like the npm version string "~2" wasn't giving us the results we wanted. I updated in PR #1102.

@lmazuel, do you want to regenerate this PR or close and start a new one?

@lmazuel
Copy link
Copy Markdown
Member Author

lmazuel commented Feb 21, 2018

@marstr I regenerate this. Thanks for the review!

@ghost ghost assigned lmazuel Feb 21, 2018
@lmazuel
Copy link
Copy Markdown
Member Author

lmazuel commented Feb 21, 2018

@marstr PR updated. Thanks!

@ghost ghost removed the review label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants