[azquery] renaming (#19490)

* change render/statistics to type []byte

* renames

* fix

* update docs

sdk/monitor/azquery/CHANGELOG.md

@@ -9,6 +9,10 @@
 
 ### Breaking Changes
 * Added error return values to `NewLogsClient` and `NewMetricsClient`
+* Rename `Batch` to `QueryBatch`
+* Rename `NewListMetricDefinitionsPager` to `NewListDefinitionsPager`
+* Rename `NewListMetricNamespacesPager` to `NewListNamespacesPager`
+* Changed type of `Render` and `Statistics` from interface{} to []byte
 
 ### Bugs Fixed
 

sdk/monitor/azquery/README.md

@@ -47,7 +47,10 @@ func main() {
 		//TODO: handle error
 	}
 
-	client := azquery.NewLogsClient(cred, nil)
+	client, error := azquery.NewLogsClient(cred, nil)
+	if err != nil {
+		//TODO: handle error
+	}
 }
 ```
 
@@ -65,7 +68,10 @@ func main() {
 		//TODO: handle error
 	}
 
-	client := azquery.NewMetricsClient(cred, nil)
+	client, err := azquery.NewMetricsClient(cred, nil)
+	if err != nil {
+		//TODO: handle error
+	}
 }
 ```
 
@@ -150,15 +156,16 @@ Results
 		|---Name *string
 		|---Type *LogsColumnType
 	|---Name *string
-	|---Rows [][]interface{}
+	|---Rows []Row
+	|---ColumnIndexLookup map[string]int
 |---Error *ErrorInfo
 	|---Code *string // custom error type
-|---Render interface{}
-|---Statistics interface{}
+|---Render []byte
+|---Statistics []byte
 ```
 
 ### Batch query
-`Batch` is an advanced method allowing users to execute multiple logs queries in a single request. It takes in a [BatchRequest](#batch-query-request-structure) and returns a [BatchResponse](#batch-query-result-structure). `Batch` can return results in any order (usually in order of completion/success). Please use the `ID` attribute to identify the correct response. 
+`QueryBatch` is an advanced method allowing users to execute multiple logs queries in a single request. It takes in a [BatchRequest](#batch-query-request-structure) and returns a [BatchResponse](#batch-query-result-structure). `QueryBatch` can return results in any order (usually in order of completion/success). Please use the `ID` attribute to identify the correct response. 
 ```go
 timespan := "2022-08-30/2022-08-31" // ISO8601 Standard Timespan
 batchRequest := azquery.BatchRequest{[]*azquery.BatchQueryRequest{
@@ -167,7 +174,7 @@ batchRequest := azquery.BatchRequest{[]*azquery.BatchQueryRequest{
 	{Body: &azquery.Body{Query: to.Ptr(kustoQuery3), Timespan: to.Ptr(timespan)}, ID: to.Ptr("3"), Workspace: to.Ptr(workspaceID)},
 }}
 
-res, err := client.Batch(context.TODO(), batchRequest, nil)
+res, err := client.QueryBatch(context.TODO(), batchRequest, nil)
 if err != nil {
 	//TODO: handle error
 }
@@ -198,14 +205,15 @@ BatchResponse
 	|---Body *BatchQueryResults
 		|---Error *ErrorInfo // custom error type
 			|---Code *string
-		|---Render interface{}
-		|---Statistics interface{}
+		|---Render []byte
+		|---Statistics []byte
 		|---Tables []*Table
 			|---Columns []*Column
 				|---Name *string
 				|---Type *LogsColumnType
 			|---Name *string
-			|---Rows [][]interface{}
+			|---Rows []Row
+			|---ColumnIndexLookup map[string]int
 	|---Headers map[string]*string
 	|---ID *string
 	|---Status *int32

sdk/monitor/azquery/autorest.md

@@ -50,10 +50,10 @@ directive:
  # rename log queries
   - rename-operation:
       from: Query_Execute
-      to: QueryWorkspace
+      to: Logs_QueryWorkspace
   - rename-operation:
       from: Query_Batch
-      to: Batch
+      to: Logs_QueryBatch
 
   # rename metric list to QueryResource
   - rename-operation:
@@ -63,10 +63,10 @@ directive:
  # rename ListMetricDefinitions and ListMetricNamespaces to generate in metrics_client.go
   - rename-operation:
       from: MetricDefinitions_List
-      to: Metrics_ListMetricDefinitions
+      to: Metrics_ListDefinitions
   - rename-operation:
       from: MetricNamespaces_List
-      to: Metrics_ListMetricNamespaces
+      to: Metrics_ListNamespaces
 
   # add default values for batch request path and method attributes
   - from: swagger-document
@@ -138,3 +138,22 @@ directive:
   - from: constants.go
     where: $
     transform: return $.replace(/const host = "(.*?)"/, "");
+
+  # change render and statistics type to []byte
+  - from: models.go
+    where: $
+    transform: return $.replace(/interface{}/g, "[]byte");
+  - from: models_serde.go
+    where: $
+    transform: return 
+      $.replace(/err(.*)r\.Statistics\)/, "r.Statistics = val") 
+  - from: models_serde.go
+    where: $
+    transform: return $.replace(/err(.*)r\.Render\)/, "r.Render = val");
+  - from: models_serde.go
+    where: $
+    transform: return 
+      $.replace(/err(.*)b\.Statistics\)/, "b.Statistics = val") 
+  - from: models_serde.go
+    where: $
+    transform: return $.replace(/err(.*)b\.Render\)/, "b.Render = val");

sdk/monitor/azquery/example_test.go

@@ -127,7 +127,7 @@ func ExampleLogsClient_QueryWorkspace_second() {
 	fmt.Println(QueryResults)
 }
 
-func ExampleLogsClient_Batch() {
+func ExampleLogsClient_QueryBatch() {
 	cred, err := azidentity.NewDefaultAzureCredential(nil)
 	if err != nil {
 		//TODO: handle error
@@ -146,7 +146,7 @@ func ExampleLogsClient_Batch() {
 		{Body: &azquery.Body{Query: to.Ptr(kustoQuery3), Timespan: to.Ptr(timespan)}, ID: to.Ptr("3"), Workspace: to.Ptr(workspaceID)},
 	}}
 
-	res, err := client.Batch(context.TODO(), batchRequest, nil)
+	res, err := client.QueryBatch(context.TODO(), batchRequest, nil)
 	if err != nil {
 		//TODO: handle error
 	}

sdk/monitor/azquery/logs_client_test.go

@@ -194,7 +194,7 @@ func TestBatch_QuerySuccess(t *testing.T) {
 	}}
 	testSerde(t, &batchRequest)
 
-	res, err := client.Batch(context.Background(), batchRequest, nil)
+	res, err := client.QueryBatch(context.Background(), batchRequest, nil)
 	if err != nil {
 		t.Fatalf("error with query, %s", err)
 	}
@@ -226,7 +226,7 @@ func TestBatch_PartialError(t *testing.T) {
 		{Body: &azquery.Body{Query: to.Ptr(query)}, ID: to.Ptr("2"), Workspace: to.Ptr(workspaceID)},
 	}}
 
-	res, err := client.Batch(context.Background(), batchRequest, nil)
+	res, err := client.QueryBatch(context.Background(), batchRequest, nil)
 	if err != nil {
 		t.Fatalf("error with query, %s", err)
 	}

sdk/monitor/azquery/metrics_client_test.go

@@ -45,7 +45,7 @@ func TestQueryResource_BasicQuerySuccess(t *testing.T) {
 func TestNewListMetricDefinitionsPager_Success(t *testing.T) {
 	client := startMetricsTest(t)
 
-	pager := client.NewListMetricDefinitionsPager(resourceURI, nil)
+	pager := client.NewListDefinitionsPager(resourceURI, nil)
 
 	// test if first page is valid
 	if pager.More() {
@@ -66,7 +66,7 @@ func TestNewListMetricDefinitionsPager_Success(t *testing.T) {
 func TestNewListMetricNamespacesPager_Success(t *testing.T) {
 	client := startMetricsTest(t)
 
-	pager := client.NewListMetricNamespacesPager(resourceURI, nil)
+	pager := client.NewListNamespacesPager(resourceURI, nil)
 
 	// test if first page is valid
 	if pager.More() {