Sync eng/common directory with azure-sdk-tools for PR 14219#6978
Merged
Sync eng/common directory with azure-sdk-tools for PR 14219#6978
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory from azure-sdk-tools PR #14219, extending the existing login-to-github.ps1 script to support GitHub Actions workflows (in addition to Azure DevOps pipelines), and adding a new composite GitHub Actions wrapper (eng/common/actions/login-to-github/action.yml) to make it easy to call that script from GH Actions.
Changes:
login-to-github.ps1updated with docs and GitHub Actions support: masks the token via::add-mask::and writes it toGITHUB_ENV, and improves the error message formatting for Key Vault signing failures.- New
eng/common/actions/login-to-github/action.ymlcomposite action that wraps the PS1 script for use in GitHub Actions, forwarding inputs as environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
eng/common/scripts/login-to-github.ps1 |
Adds GitHub Actions token export/masking, updates docs/comments, and tweaks the KV sign error message. |
eng/common/actions/login-to-github/action.yml |
New composite GitHub Actions action wrapping the PS1 script with all required inputs and example usage. |
weshaggard
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14219 See eng/common workflow