Sync eng/common directory with azure-sdk-tools for PR 13968#6956
Sync eng/common directory with azure-sdk-tools for PR 13968#6956chidozieononiwu merged 2 commits intomainfrom
Conversation
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull request overview
This pull request syncs the eng/common directory with azure-sdk-tools PR #13968. The change introduces a new AdditionalParameters parameter to distinguish between ARM template parameters and other additional parameters passed to the test resource deployment script.
Changes:
- Added new
AdditionalParametersparameter to the YAML template - Renamed the usage of
-AdditionalParametersto-ArmTemplateParametersfor the original ARM template parameters - Added new
-AdditionalParametersparameter usage for the new AdditionalParameters field
| @subscriptionConfiguration ` | ||
| -AdditionalParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -ArmTemplateParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` |
There was a problem hiding this comment.
Missing dollar sign prefix in parameter expansion. The expression should be ${{ parameters.AdditionalParameters }} instead of {{ parameters.AdditionalParameters }}. Without the $ prefix, this will not be properly expanded and will cause the script invocation to fail. All other parameter expansions in this file consistently use the ${{ }} syntax.
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` | |
| -AdditionalParameters ${{ parameters.AdditionalParameters }} ` |
| @subscriptionConfiguration ` | ||
| -AdditionalParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -ArmTemplateParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` |
There was a problem hiding this comment.
Missing dollar sign prefix in parameter expansion. The expression should be ${{ parameters.AdditionalParameters }} instead of {{ parameters.AdditionalParameters }}. Without the $ prefix, this will not be properly expanded and will cause the script invocation to fail. All other parameter expansions in this file consistently use the ${{ }} syntax.
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` | |
| -AdditionalParameters ${{ parameters.AdditionalParameters }} ` |
azure-sdk
force-pushed
the
sync-eng/common-EnableLiveTestOverHttp-13968
branch
from
c891452 to
04de30e
Compare
chidozieononiwu
deleted the
sync-eng/common-EnableLiveTestOverHttp-13968
branch
2 participants
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13968 See eng/common workflow