Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12350 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner December 8, 2025 20:30
@azure-sdk azure-sdk requested review from benbp and Copilot December 8, 2025 20:30
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools for PR #12350, updating stress testing deployment scripts with cluster naming changes and improved validation logic.

Key changes:

  • Updates cluster group names to use the "SSS3PT_" prefix for pg, prod, and storage environments
  • Adds validation to detect uncommitted changes to values.yaml and prompts users to use the -LocalAddonsPath parameter

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 Updates cluster group resource names with "SSS3PT_" prefix for three environments (pg, prod, storage)
eng/common/scripts/stress-testing/deploy-stress-tests.ps1 Adds git-based validation to detect local values.yaml changes and require explicit -LocalAddonsPath parameter

@benbp benbp merged commit d5e3416 into main Dec 22, 2025
24 of 50 checks passed
@benbp benbp deleted the sync-eng/common-benbp/stress-sss3pt-12350 branch December 22, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants