Add unit tests for Base64Url encode and decode methods in Core#6804
Merged
RickWinter merged 4 commits intomainfrom Oct 23, 2025
Merged
Add unit tests for Base64Url encode and decode methods in Core#6804RickWinter merged 4 commits intomainfrom
RickWinter merged 4 commits intomainfrom
Conversation
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests for Base64Url encode and decode methods
Add unit tests for Base64Url encode and decode methods in Core
Oct 22, 2025
RickWinter
reviewed
Oct 22, 2025
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
LarryOsterman
requested changes
Oct 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the Base64Url encoding and decoding methods in azure-core, addressing a test coverage gap where these functions were only indirectly tested through the Attestation SDK.
Key changes:
- Added 8 new test cases covering Base64Url encode/decode functionality with 222 lines of test code
- Tests cover basic operations, edge cases, special character replacement, padding handling, invalid input, and roundtrip verification
- Applied clang-format to ensure code formatting compliance
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
LarryOsterman
approved these changes
Oct 23, 2025
antkmsft
approved these changes
Oct 23, 2025
Member
|
@microsoft-github-policy-service rerun |
Member
|
/check-enforcer evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successfully added 8 comprehensive unit tests (222 lines) for Base64Url encode/decode methods in azure-core with proper formatting and accurate comments.
Test Cases:
Recent fixes:
Original prompt
Fixes #5424
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.