Sync eng/common directory with azure-sdk-tools for PR 11974#6723
Conversation
azure-sdk
added
EngSys
azure-sdk
force-pushed
the
sync-eng/common-add_optional_release_plan_id-11974
branch
from
1e33056 to
864a566
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools repository to add functionality for updating pull request information in release plan work items. The changes introduce a new PowerShell script and helper functions to manage pull request URLs and status updates within Azure DevOps work items.
Key changes:
- Added a new PowerShell script to update pull request information in release plans
- Extended DevOps work item helpers with functions to manage pull request data and retrieve release plan links
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Update-PullRequest-In-ReleasePlan.ps1 | New script that accepts parameters for updating pull request URLs and status in release plan work items |
| eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 | Added helper functions for updating pull request information and retrieving release plan links |
| $releasePlan = Get-ReleasePlan-Link $ReleasePlanWorkItemId | ||
| if (!$releasePlan) | ||
| { | ||
| LogError "Release plan with ID $ReleasePlanWorkItemId not found." |
There was a problem hiding this comment.
The script continues execution after logging an error when the release plan is not found. This will cause the Update-PullRequestInReleasePlan function call on line 46 to proceed with a null/invalid work item ID, which could lead to unexpected behavior or errors. Add a return statement or exit after the LogError call.
| LogError "Release plan with ID $ReleasePlanWorkItemId not found." | |
| LogError "Release plan with ID $ReleasePlanWorkItemId not found." | |
| exit 1 |
azure-sdk
force-pushed
the
sync-eng/common-add_optional_release_plan_id-11974
branch
from
864a566 to
0087b3b
Compare
azure-sdk
force-pushed
the
sync-eng/common-add_optional_release_plan_id-11974
branch
from
0087b3b to
db771df
Compare
praveenkuttappan
deleted the
sync-eng/common-add_optional_release_plan_id-11974
branch
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11974 See eng/common workflow