Identity perf pipeline run triggers#5892
Merged
gearama merged 5 commits intoAzure:mainfrom Aug 12, 2024
gearama:Identitypipeline
Merged
Identity perf pipeline run triggers#5892gearama merged 5 commits intoAzure:mainfrom gearama:Identitypipeline
gearama merged 5 commits intoAzure:mainfrom
gearama:Identitypipeline
Conversation
gearama
requested review from
a team,
LarryOsterman,
RickWinter,
ahsonkhan,
antkmsft and
schaabs
as code owners
LarryOsterman
approved these changes
Aug 12, 2024
Member
LarryOsterman
left a comment
LarryOsterman
left a comment
There was a problem hiding this comment.
Could you please improve the title and/or comment so that it appears better when this is committed
This was referenced Aug 13, 2024
ahsonkhan
reviewed
Aug 13, 2024
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
Do we need a similar change in other perf.yml files in the repo, such as the one in core?
I am not sure if the following is setup to run the perf pipelines for core, whenever Azure.Core files are changed:
azure-sdk-for-cpp/sdk/core/perf.yml
Line 1 in cf562e0
Contributor
For example, see this, where only When do we expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5423
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.