Skip to content

Update README.md#4672

Closed
scottaddie wants to merge 8 commits into
mainfrom
scottaddie/fix-dac-image
Closed

Update README.md#4672
scottaddie wants to merge 8 commits into
mainfrom
scottaddie/fix-dac-image

Conversation

@scottaddie
Copy link
Copy Markdown
Member

No description provided.

@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented May 31, 2023

Looks like this change is blocked by an unrelated clang-format issue, likely introduced in one of the recent changes to etag_test.cpp:
Looks like these two PRs conflicted with each other and caused the double header include for gtest.h:
#4656
#4632

https://dev.azure.com/azure-sdk/public/_build/results?buildId=2811177&view=logs&j=5312c7ff-5558-5a0c-4f25-5356448c148b&t=5ee665bd-8bc0-590e-7be1-fd4d1361eaaf&l=20

Check clang-formatting
Ubuntu clang-format version 11.0.0-2~ubuntu20.04.1
Some files were not formatted correctly according to the .clang-format file.
Please run clang-format version 10 or greater to fix the issue by using this bash command at the root of the repo:
find ./sdk \( -iname '*.hpp' -o -iname '*.cpp' \) ! -iname 'json.hpp' -exec clang-format -i {} \;

List of files not formatted correctly:
sdk/core/azure-core/test/ut/etag_test.cpp
##[error]Bash exited with code '1'.

The issue has been fixed in #4673

Jinming-Hu and others added 7 commits May 31, 2023 11:34
Storage May Beta Release
* Updated typespec common script

* Updated per the review comment

---------

Co-authored-by: raychen <raychen@microsoft.com>
* Revert the change and return tsplocation folder

* Out null for the new-item command

* exit if return failure when call sync script

* Added repo assignment in local path scenario

* Added more output

* Fix path processing in windows

* exit when run generate script with error

---------

Co-authored-by: raychen <raychen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants