Convert most AMQP types to read-only; Significant API surface cleanup.

sdk/core/azure-core-amqp/CMakeLists.txt

@@ -43,6 +43,7 @@ set (AZURE_CORE_AMQP_HEADER
     inc/azure/core/amqp/common/global_state.hpp
     inc/azure/core/amqp/connection.hpp
     inc/azure/core/amqp/connection_string_credential.hpp
+    inc/azure/core/amqp/endpoint.hpp
     inc/azure/core/amqp/link.hpp
     inc/azure/core/amqp/message_receiver.hpp
     inc/azure/core/amqp/message_sender.hpp

sdk/core/azure-core-amqp/README.md

@@ -1,15 +1,16 @@
 # Azure SDK AMQP Library for C++
 
 Azure::Core::Amqp (`azure-core-amqp`) provides an implementation
-to enable developers to create Azure SDKs which consume the AMQP protocol.
+to enable developers to create Azure SDKs which consume the AMQP protocol. Note that this is *NOT* a general purpose AMQP library, it is intended solely for the purposes of 
+building Azure C++ SDK clients which communicate with Azure services over AMQP.
 
 ## Getting started
 
 ### Include the package
 
-The easiest way to acquire the OpenTelemetry library is leveraging vcpkg package manager. See the corresponding [Azure SDK for C++ readme section][azsdk_vcpkg_install].
+The easiest way to acquire the AMQP library is leveraging vcpkg package manager. See the corresponding [Azure SDK for C++ readme section][azsdk_vcpkg_install].
 
-To install Azure Core OpenTelemetry package via vcpkg:
+To install Azure Core AMQP package via vcpkg:
 
 ```cmd
 > vcpkg install azure-core-amqp-cpp
@@ -24,6 +25,16 @@ target_link_libraries(<your project name> PRIVATE Azure::azure-core-amqp)
 
 ## Key concepts
 
+The AMQP Protocol is a relatively complicated protocol which is used by Azure services to communicate with clients. This library provides a
+set of classes which can be used to build Azure SDK clients which communicate with Azure services over AMQP.
+
+The AMQP library provides the following classes:
+
+- AmqpClient - The basic client used to communicate with the AMQP server.
+- MessageSender - A class which is used to send messages to an AMQP server.
+- MessageReceiver - A class which is used to receive messages from an AMQP server.
+
+
 
 
 ## Examples

sdk/core/azure-core-amqp/inc/azure/core/amqp/claims_based_security.hpp

@@ -15,7 +15,7 @@ namespace Azure { namespace Core { namespace Amqp { namespace _detail {
     Ok,
     Error,
     Failed,
-    InstanceClosed
+    InstanceClosed,
   };
 
   enum class CbsOpenResult
@@ -30,7 +30,7 @@ namespace Azure { namespace Core { namespace Amqp { namespace _detail {
   {
     Invalid,
     Sas,
-    Jwt
+    Jwt,
   };
 
 #if defined(TESTING_BUILD)

sdk/core/azure-core-amqp/inc/azure/core/amqp/common/async_operation_queue.hpp

@@ -78,7 +78,7 @@ namespace Azure { namespace Core { namespace Amqp { namespace Common { namespace
 
     void Poll() {}
 
-    template <class PT, class... Ts> void Poll(PT const& first, Ts const&... rest)
+    template <class PT, class... Ts> void Poll(PT & first, Ts &... rest)
     {
       first.Poll();
       Poll(rest...);