Merge main into feature/amqp. #4491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add GetCredentialName() * Update * Undo accidental change * Clang-format * Call GetCredentialName() instead of using constant; Return in-place constructed name; Explicit tests for GetCredentialName() * PR feedback * constructor parameter + non-virtual GetCredentialName() * Update sdk/core/azure-core/CMakeLists.txt * Update sdk/identity/azure-identity/test/ut/client_secret_credential_test.cpp * Update sdk/identity/azure-identity/test/ut/client_certificate_credential_test.cpp * GCC and Clang warnings * Promote ThrowIfNotSafeCmdLineInput() to private member; avoid copies when calling GetCredentialName() * Spelling * Fix deprecated usage * Fix iteration * Clang-format --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* add healthinsights to Test-SampleMetadata script * spacing * update productSlug to azure-health-insights --------- Co-authored-by: Asaf Levi <asaflevi@microsoft.com>
* Use aka.ms link to Identity troubleshooting * Update default_azure_credential.cpp * Update default_azure_credential.cpp --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
…vate ctor (#4447) * Undocument ChainedCred usage by DefaultAzCred & remove friend and private ctor * Clang warning fix --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* typespec renaming * add back scripts for cadl * support .cadl and .tsp * rename * add newline at the end of file --------- Co-authored-by: FAREAST\chunyu <chunyu@microsoft.com>
* fix cspell * capitalize Valgrind and ubuntu * sdada * fix2
* Simpler identity logging * Even simpler * Remove refactoring artifact * Cosmetic change * foreach --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Adding guidance on the proper usage of 3rd Party Libraries in our samples.
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Tests: replace most `EXPECT_TRUE(a OP b)` with `EXPECT_OP(a, b)` * Undo unnecessary change --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Fix potentially high CPU usage on Windows * Undo unnecessary formatting * Undo unnecessary changelog * Undo unnecessary formatting * Undo unnecessary formatting * Uninclude locale * Add issue link to changelog * EXPECT_TRUE(a == b) => EXPECT_EQ(a, b) * Update second changelog with link as well --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Ensure the comparison is unsigned to unsigned * Remove cast
* add some default output to see about minimizing any occurrence of the task failing for no reason. perhaps having some output will allow devops to have an easier time with the invocation * update message * Update eng/common/scripts/trust-proxy-certificate.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Fixup an invalid user
* Organize applying Identity log prefix * logLevel * Cosmetic changes --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
…script (#4481) https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.3#psnativecommandargumentpassing Do to that breaking change in PS 7.3 we need to opt into the legacy arg parsing. Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* rerun flag * rerun failed stress test * naming & commenting * update * function and var renaming for better readability * readability & exit on error --------- Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
LarryOsterman
requested review from
EmmaZhu,
Jinming-Hu,
RickWinter,
antkmsft,
benbp,
danieljurek,
jsquire,
ronniegeraghty,
vinjiang and
weshaggard
as code owners
LarryOsterman
requested review from
ahmadmsft,
ahsonkhan,
anilba06,
gearama,
gkostal,
microzchang,
schaabs and
vhvb1989
as code owners
Member
Author
|
/check-enforcer bypass |
|
For help using check enforcer, see https://aka.ms/azsdk/checkenforcer Available commands:
If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run |
Member
Author
|
/check-enforcer override |
1 similar comment
Member
Author
|
/check-enforcer override |
Member
Author
|
Ping :). |
Contributor
I think we should disable the Do you agree @LarryOsterman and others? |
ahsonkhan
approved these changes
Mar 30, 2023
Member
Author
I don't have a problem with making that change. I've had exactly zero luck reproducing the public environment to look at the failure locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.