Skip to content

Ensure the comparison is unsigned to unsigned #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RickWinter merged 2 commits into from
Mar 21, 2023
Merged

Ensure the comparison is unsigned to unsigned #4464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a8cd12
Ensure the comparison is unsigned to unsigned
RickWinter Mar 21, 2023
7dbaae8
Remove cast
RickWinter Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions sdk/keyvault/azure-security-keyvault-keys/test/ut/key_cryptographic_client_test_live.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteEncrypt)
= cryptoClient->Encrypt(EncryptParameters::RsaOaepParameters(plaintext)).Value;
EXPECT_EQ(encryptResult.Algorithm.ToString(), EncryptionAlgorithm::RsaOaep.ToString());
EXPECT_EQ(encryptResult.KeyId, rsaKey.Id());
EXPECT_GT(encryptResult.Ciphertext.size(), 0);
EXPECT_GT(encryptResult.Ciphertext.size(), 0u);

auto decryptResult
= cryptoClient->Decrypt(DecryptParameters::RsaOaepParameters(encryptResult.Ciphertext))
Expand Down Expand Up @@ -68,7 +68,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteWrap)
auto wrapResult = cryptoClient->WrapKey(KeyWrapAlgorithm::RsaOaep256, plaintext).Value;
EXPECT_EQ(wrapResult.Algorithm.ToString(), KeyWrapAlgorithm::RsaOaep256.ToString());
EXPECT_EQ(wrapResult.KeyId, rsaKey.Id());
EXPECT_GT(wrapResult.EncryptedKey.size(), 0);
EXPECT_GT(wrapResult.EncryptedKey.size(), 0u);

auto unwrapResult
= cryptoClient->UnwrapKey(wrapResult.Algorithm, wrapResult.EncryptedKey).Value;
Expand Down Expand Up @@ -102,7 +102,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyRSA256)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand All @@ -121,7 +121,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyRSA256)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand Down Expand Up @@ -152,7 +152,7 @@ TEST_F(KeyVaultKeyClient, RemoteSignVerifyES256)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, ecKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand All @@ -176,7 +176,7 @@ TEST_F(KeyVaultKeyClient, RemoteSignVerifyES256)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, ecKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand Down Expand Up @@ -210,7 +210,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyRSA384)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand All @@ -229,7 +229,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyRSA384)
auto signResult = cryptoClient->Sign(signatureAlgorithm, digest).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->Verify(signResult.Algorithm, digest, signResult.Signature).Value;
Expand Down Expand Up @@ -260,7 +260,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyDataRSA256)
auto signResult = cryptoClient->SignData(signatureAlgorithm, data).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->VerifyData(signResult.Algorithm, data, signResult.Signature).Value;
Expand All @@ -275,7 +275,7 @@ TEST_P(KeyVaultKeyClientWithParam, RemoteSignVerifyDataRSA256)
auto signResult = cryptoClient->SignData(signatureAlgorithm, data).Value;
EXPECT_EQ(signResult.Algorithm.ToString(), signatureAlgorithm.ToString());
EXPECT_EQ(signResult.KeyId, rsaKey.Id());
EXPECT_GT(signResult.Signature.size(), 0);
EXPECT_GT(signResult.Signature.size(), 0u);

auto verifyResult
= cryptoClient->VerifyData(signResult.Algorithm, data, signResult.Signature).Value;
Expand Down Expand Up @@ -305,7 +305,7 @@ TEST_P(KeyVaultKeyClientWithParam, GetCryptoFromKeyRemoteEncrypt)
= cryptoClient.Encrypt(EncryptParameters::RsaOaepParameters(plaintext)).Value;
EXPECT_EQ(encryptResult.Algorithm.ToString(), EncryptionAlgorithm::RsaOaep.ToString());
EXPECT_EQ(encryptResult.KeyId, rsaKey.Id());
EXPECT_GT(encryptResult.Ciphertext.size(), 0);
EXPECT_GT(encryptResult.Ciphertext.size(), 0u);

auto decryptResult
= cryptoClient.Decrypt(DecryptParameters::RsaOaepParameters(encryptResult.Ciphertext))
Expand Down Expand Up @@ -336,7 +336,7 @@ TEST_P(KeyVaultKeyClientWithParam, GetCryptoFromKeyVersionRemoteEncrypt)
= cryptoClient.Encrypt(EncryptParameters::RsaOaepParameters(plaintext)).Value;
EXPECT_EQ(encryptResult.Algorithm.ToString(), EncryptionAlgorithm::RsaOaep.ToString());
EXPECT_EQ(encryptResult.KeyId, rsaKey.Id());
EXPECT_GT(encryptResult.Ciphertext.size(), 0);
EXPECT_GT(encryptResult.Ciphertext.size(), 0u);

auto decryptResult
= cryptoClient.Decrypt(DecryptParameters::RsaOaepParameters(encryptResult.Ciphertext))
Expand Down