Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format#4360
Merged
konrad-jamrozik merged 9 commits intomainfrom Feb 17, 2023
Conversation
Updating used images to their compliant versions. - Azure/azure-sdk-tools#3407
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
benbp,
danieljurek and
weshaggard
as code owners
mikeharder
approved these changes
Feb 15, 2023
Member
mikeharder
left a comment
mikeharder
left a comment
There was a problem hiding this comment.
I believe this is functionally a no-op, but it's good to align with the actual image used.
weshaggard
reviewed
Feb 15, 2023
weshaggard
reviewed
Feb 15, 2023
weshaggard
reviewed
Feb 15, 2023
weshaggard
reviewed
Feb 15, 2023
weshaggard
reviewed
Feb 15, 2023
weshaggard
reviewed
Feb 15, 2023
konrad-jamrozik
changed the title
azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format
konrad-jamrozik
commented
Feb 17, 2023
konrad-jamrozik
commented
Feb 17, 2023
eng/common/pipelines/templates/stages/archetype-sdk-tool-pwsh.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Overriding for the same reason as here @danieljurek @benbp FYI |
Contributor
Author
|
/check-enforcer override |
antkmsft
pushed a commit
that referenced
this pull request
Apr 5, 2023
…22-general` and rename `vmImage` to the `windows-20xx` format (#4360)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where applicable, update Windows pools used to
azsdk-pool-mms-win-2022-generaland renamevmImageto thewindows-20xxformat.This discussion explains why we chose given
vmImageformat:Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM
For further context, please see:
WindowsandUbuntuagent pools to consume2022-Compliantimages azure-sdk-tools#3407WARNING
The code is still using non-compliant
azsdk-pool-mms-win-2019-generalpools which cannot be updated at this time. As a consequence, the build may fail once the images will be force-migrated to compliant ones on March 1st.