Skip to content

Disable warning C6387 coming from wil in win_http_transport due to SAL annotation #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahsonkhan merged 4 commits into from
Nov 28, 2022
Merged

Disable warning C6387 coming from wil in win_http_transport due to SAL annotation #4132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2427911
Disable warning C6387 coming from wil in win_http_transport
ahsonkhan Nov 28, 2022
d8d97b1
Disable warning C6387 coming from wil in win_http_transport header
ahsonkhan Nov 28, 2022
9534292
Clang format fix for header file
ahsonkhan Nov 28, 2022
458ee51
Clang format fix for source file
ahsonkhan Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/core/azure-core/src/http/winhttp/win_http_request.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include <mutex>
#pragma warning(push)
#pragma warning(disable : 6553)
#pragma warning(disable : 6387) // An argument in result_macros.h may be '0', for the function
// 'GetProcAddress'.
#include <wil\resource.h>
#pragma warning(pop)
#include <winhttp.h>
Expand Down
2 changes: 2 additions & 0 deletions sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
#include <string>
#pragma warning(push)
#pragma warning(disable : 6553)
#pragma warning(disable : 6387) // An argument in result_macros.h may be '0', for the function
// 'GetProcAddress'.
#include <wil/resource.h> // definitions for wil::unique_cert_chain_context and other RAII type wrappers for Windows types.
#pragma warning(pop)

Expand Down