Conversation
|
/azp run cpp - keyvault -ci |
|
/azp run cpp - keyvault - ci |
sdk/core/azure-core-test/inc/azure/core/test/test_proxy_manager.hpp
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/inc/azure/core/test/test_proxy_policy.hpp
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/inc/azure/core/test/test_proxy_policy.hpp
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/inc/azure/core/test/test_proxy_policy.hpp
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_delete_test_live.cpp
Show resolved
Hide resolved
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Some comments and questions to try and understand some of the rationale for changes made here.
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_rotation_policy_test_live.cpp
Show resolved
Hide resolved
sdk/attestation/azure-security-attestation/test/ut/policygetset_test.cpp
Show resolved
Hide resolved
sdk/core/azure-core-test/inc/azure/core/test/test_proxy_manager.hpp
Outdated
Show resolved
Hide resolved
RickWinter
left a comment
RickWinter
left a comment
There was a problem hiding this comment.
Added some feedback. I'll review again once addressed.
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
Thank you for the ton of work you have done here. I am glad to see these recording files gone from the source tree. This is a great change.
Other guys have left pretty good feedback - suggestions and questions. I agree with them.
Once they are resolved/applied/answered, I see no blockers to merge this PR.
Jinming-Hu
left a comment
Jinming-Hu
left a comment
There was a problem hiding this comment.
The changes to storage looks good to me.
We can look into the disabled test cases later. I don't want to block this PR.
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
6 participants
Replaces the homegrown test-proxy with the commn one used by other languages, created byt the ENG team . (https://github.com/Azure/azure-sdk-tools/tree/main/tools/test-proxy )
One bebefit is that the test recordings are kept in a separate repo ( https://github.com/Azure/azure-sdk-assets) from where the tests are restored at playback time.
All recordinggs have been moved to the new location. A few misbehaving tests(<10) have been switched to LIVEONLY , a bug has been filed for those to keep track
To install the proxy locally and run it read : https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md#installation
or execute "\eng\scripts\Start-TestProxy.ps1 -AssetsPath <sdk/service> "
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.