Sync Main branch with WebSockets branch.#4072
Merged
LarryOsterman merged 135 commits intoAzure:feature/websocketsfrom Nov 1, 2022
Merged
Sync Main branch with WebSockets branch.#4072LarryOsterman merged 135 commits intoAzure:feature/websocketsfrom
LarryOsterman merged 135 commits intoAzure:feature/websocketsfrom
Conversation
* mem leak fix * PR comments fix * PR comments * seems to work? * clang * curl again * add first stress test * also update gitignore * missing line * only linux * clang typo format * typo 2 * PR comments * cspell * remove terminator
Co-authored-by: sima-zhu <sizhu@microsoft.com>
… required. (Azure#3830) * Update attestation core vcpkg dependency to latest GA version that is required. * Update vcpkg config.cmake to match the dependency version needed.
* remove refs to winhttp * this tsst only curl
Co-authored-by: Mike Harder <mharder@microsoft.com>
* someone wants to reference the test-proxy startup scripts externally. to make this easy on them we're parameterizing the root of the eng/common for easy use in that scenario * two leading $ signs on the definition of the certificate path was causing some issues! Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Add language-service to list of valid sample slugs * Update link to taxonomies Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Set up for testing of template pipeline * Override branches, set up for template GA release * More TODOs to prevent merging an unintended change * More removal of TestPipeline * Increment template version number * Use script to set package version * Check out the correct branch * branch parameter in the command * Use $(PublishToVcpkg) to determine if we should check for changes * dictionary syntax * Set GA package version to validate GA publish scenario * Update changelog * create-pull-request.yml optionally pushes changes * Output GH PR URI * Macro syntax with a variable set earlier * Move up to 1.2.0-beta.2 * beta.1 * Revert changelog * Revert testing-related changes * Revert vcpkg-clone.yml * Revert eng/common changes, ensure global $(HasChanges) is set properly * Changes to enable testing * 1.1.0-beta.1 * vcpkg clone should clone at configured branch * Clone "main" branch of vcpkg betas * Undo test-specific changes * More PR cleanup * PR cleanup
* helm chart * first pipe setup * poi * magiks * ewewe * stress * cleanup * pr * QFE and readme * clang * stupid clang , waste of time * ewqwewewrqrewewrqewrqwrqr * stupid clang * cspell * PR * try try again * clang again
* Add full clone fallback to sparse checkout * Improve clone handling and overrides for sparse checkout * Use SkipSparseCheckout variable name Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Detect API changes using new snadboxinx approach * Added strictmode * Remove unset variable * Changes as per strict mode 3 * Rervert strict mode to allow language level fixes to merge first Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Increment package version after release of azure-security-keyvault-keys * Increment package version after release of azure-security-keyvault-secrets * Increment package version after release of azure-security-keyvault-certificates
…re#3851) This reverts commit 7605ead00308dd20f20f2afe5acc4ec9900a2c47. Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Bump MacOs version to macos-11 * Update eng/common/scripts/job-matrix/tests/job-matrix-functions.tests.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/scripts/job-matrix/tests/job-matrix-functions.tests.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: sima-zhu <sizhu@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
When signals are delievered to the process, calls here to poll may be interrupted and return with a spurious failure. The call instead should be restarted.
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Add link checking for stress CI * Remove region segment from stress testing links Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Core August releases * cspell Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-core * Increment package version after release of azure-core-tracing-opentelemetry
* Condition added and indentation changes
* updating pfx and cert * update the targeted version of the proxy as well Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Storage August Preview Release * update versions
antkmsft
reviewed
Oct 28, 2022
antkmsft
approved these changes
Oct 28, 2022
Member
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
It is hard to review these many changes. If there anything specific that needs review, LMK.
Is my understanding that you pulled changes from main and merging them into a feature branch, and it does not have unique changes correct? But then I see no Identity changes that went in recently...
Member
Author
See the pull request comment. I recently updated it to include exactly what was changed. Basically there were huge changes to the WinHTTP transport to accommodate the fact that WebSockets can have simultaneous read, write and close operations simultaneously while HTTP can only have a single operation at a time. |
Member
|
@LarryOsterman, ah I see, thank you! I compared changes from your personal branch to main, LGTM. |
* Added ability to switch to OpenSSL 1.1.1n * Fixed OpenSSL compilation challenges - the CRL stuff works now * Added instructions on using OpenSSL 1.1.1 to README * Added vcpkg args to handle openssl variants
…rryOsterman/azure-sdk-for-cpp into larryo/syncwebsocketswithmain
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge changes from Main branch to the feature/websockets branch.
Unlike previous PRs, there are significant changes to the WInHttp transport to reflect the different use patterns for WebSockets.
Places to look for changes:
azure\core\azure-core\src\azure\core\http
azure\core\azure-core\src\environment_log_level_listener.cpp (changed code to clean up logging in multithreaded environments)
azure\core\azure-core\inc\azure\core\http
It's unfortunate but the changes made to win_http_transport.cpp include both the existing changes in main and the accommodations needed to handle websockets :(.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.