Skip to content

Update VCPKG Baseline due to zlib #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gearama merged 4 commits into from
Oct 14, 2022
Merged

Update VCPKG Baseline due to zlib #4027

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03784c6
override zlib version
gearama Oct 14, 2022
bbcb417
shwitch baseline
gearama Oct 14, 2022
b5e6a40
macro update
gearama Oct 14, 2022
402a875
override zlib
gearama Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@
"name": "wil",
"platform": "windows"
}
],
"overrides": [
{
"name": "zlib",
"version": "1.2.12#2"
Copy link
Member

@Jinming-Hu Jinming-Hu Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the latest version on vcpkg is still 1.2.12. https://github.com/microsoft/vcpkg/blob/06b5f4a769d848d1a20fa0acd556019728b56273/ports/zlib/vcpkg.json#L3

How do we build the repo locally with 1.2.12#2?

Copy link
Member

@LarryOsterman LarryOsterman Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using a current vcpkg.exe, then the overrides should resolve the problem. Sync your vcpkg repo to the current master branch and I believe it should resolve the issue.

}
]
}